Rails Ruby on Rails

Comments and changes to this ticket

• 

  Jeff Kreeftmeijer October 10th, 2010 @ 08:39 AM

  • Tag set to “memcache, patch, warning”
  • Importance changed from “” to “Low”

  This message never told you to put "memcache" in your Gemfile. It said you don't have a thing called "memcache" installed. I understand how this can be misleading, though.

  +1

• You flagged this item as spam.
  

  Wincent Colaiuta October 10th, 2010 @ 10:41 AM

  No, it did tell you to put "memcache" in your Gemfile; read what it says:

  You don't have memcache installed in your application. Please add it to your Gemfile

  Please at "it" to your Gemfile, where "it" here can only refer to "memcache".

• 

  Jeff Kreeftmeijer October 10th, 2010 @ 12:08 PM

  Again, I know it was misleading, but it told you to require memcache (the library), not to add "memcache" (the string) to your Gemfile. I completely agree with your patch, though. :)

• 

  Jeff Kreeftmeijer October 10th, 2010 @ 12:08 PM

  • Title changed from “[PATCH] Fix misleading advice to add 'memcache' to Gemfile” to “Fix misleading advice to add 'memcache' to Gemfile”

• You flagged this item as spam.
  

  Wincent Colaiuta October 10th, 2010 @ 12:21 PM

  it told you to require memcache (the library), not to add "memcache" (the string) to your Gemfile.

  So, you're saying that "Please add it to your Gemfile" means "Require it". Rubbish.

• 

  Repository October 10th, 2010 @ 05:30 PM

  • State changed from “new” to “committed”

  (from [f659a1576fc4a447bbfbd866c7244d8d790a3d9c]) Fix misleading advice to add 'memcache' to Gemfile

  [#5539 state:committed]

  Commit 57144388f removed the hard-coded dependency on the memcache-client
  gem, and added this warning advising people to install it if needed. The
  problem is, however, that if people follow the advice literally and install
  the 'memcache' gem, they will wind up with a completely different thing,
  which is not API compatible with the memcache-client gem and which Rails
  can't work with.

  So, be explicit and tell users to install the 'memcache-client' gem.

  Signed-off-by: Santiago Pastorino santiago@wyeworks.com
  http://github.com/rails/rails/commit/f659a1576fc4a447bbfbd866c7244d...

• 

  Repository October 10th, 2010 @ 05:30 PM

  (from [3a6acb616235349f829236ec04a182d27fe2d397]) Fix misleading advice to add 'memcache' to Gemfile

  [#5539 state:committed]

  Commit 57144388f removed the hard-coded dependency on the memcache-client
  gem, and added this warning advising people to install it if needed. The
  problem is, however, that if people follow the advice literally and install
  the 'memcache' gem, they will wind up with a completely different thing,
  which is not API compatible with the memcache-client gem and which Rails
  can't work with.

  So, be explicit and tell users to install the 'memcache-client' gem.

  Signed-off-by: Santiago Pastorino santiago@wyeworks.com
  http://github.com/rails/rails/commit/3a6acb616235349f829236ec04a182...

• 

  Ryan Bigg October 11th, 2010 @ 12:09 PM

  • Tag cleared.

  Automatic cleanup of spam.