This project is archived and is in readonly mode.

#5550 ✓stale
Jakub Okoński

Delete useless constructor in XML Serializers

Reported by Jakub Okoński | September 3rd, 2010 @ 04:57 PM

I think this constructor is useless, as to_xml triggers the second constructor, which is working fine.
Jose commited at 29 April with an error in this not used constructor and it has been undetected for few months now.
http://github.com/rails/rails/commit/2e9af3638d950ef840e1287f99e323...

Also, andreas's tests of new patch that fixed this undetected error are wrong, as they use to_xml which triggers other constructor (not that one he fixed).

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Pages