This project is archived and is in readonly mode.
Delete useless constructor in XML Serializers
-
Jakub OkońskiHaving some problems with lighthouse attachments, here is a patch:
http://gist.github.com/564092 -
-
José Valim
Why do we need to delete the test? Does it pass or fail after your changes?
-
Jakub Okoński
The test is wrong, because it triggers working construcor of XML Serializer. This one, that I call 'useless' is not triggered by any other function, so why keeping it?
-
José Valim
In any case, Andrea have found an issue. Shouldn't we have a test for the issue he found?
-
Jakub Okoński
This test of his is wrong, because it triggers not this function that he fixed, but the other.
Post.where(:id => 12345).first.to_xml triggers second constructor(def initialize), not the one he fixed.
I'll try to fix his test and post a patch.
-
Jakub Okoński
Please test this one, as my bundler installation is broken someone.
-
Jakub Okoński
Got myself really confused by all this... try this one:
-
José Valim
- State changed from new to incomplete
Applying your patch that removes the constructor causes several ActiveModel tests to fail.
-
Santiago Pastorino
- State changed from incomplete to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
