Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

actionpack 2.3.9 form_helper_test test failures

#5554

When running actionpack's tests I get the following test failures (I've picked one for brevity, the other 23 are similar):

 24) Failure:
test_text_area_with_size_option(FormHelperTest)
    [/var/tmp/portage/dev-ruby/actionpack-2.3.9/work/all/actionpack-2.3.9/lib/action_controller/test_case.rb:119:in `clean_backtrace'
     ./test/template/form_helper_test.rb:411:in `test_text_area_with_size_option'
     /usr/lib64/ruby/gems/1.8/gems/activesupport-2.3.9/lib/active_support/testing/setup_and_teardown.rb:57:in `__send__'
     /usr/lib64/ruby/gems/1.8/gems/activesupport-2.3.9/lib/active_support/testing/setup_and_teardown.rb:57:in `run']:
<"<textarea name=\"post[body]\" id=\"post_body\" rows=\"820\" cols=\"183\">Back to the hill and over it again!</textarea>"> expected but was
<"<textarea name=\"post[body]\" id=\"post_body\" rows=\"820\" cols=\"183\">What a wonderful world!</textarea>">.

As far as I can tell this happens because both form_helper_test.rb and record_tag_helper_test.rb define a global Post object. Since 'rake test' requires the test files in alphabetical order the definition in record_tag_helper_test.rb wins and the form_helper_test.rb stuff gets to use that Post instead of the one defined in its own file.

Indeed, running each test manually works fine. I'm not sure what the best way to fix this is, and I'm also not sure why this worked for actionpack 2.3.8 because it looks like nothing significant changed.

Reported by Hans de Graaff · September 5th, 2010 @ 09:07 AM

State: resolved
Milestone: none
Assigned to: nobody
Importance: Low

Activity

  1. Jeff Kreeftmeijer
    Jeff Kreeftmeijer
    • State changed from new to invalid
    • Importance changed from to Low

    The tests seem to be working now, I'll close this ticket. If you're still experiencing this issue, please let me know so I can reopen it. :)

    October 11th, 2010 @ 04:28 PM

  2. Hans de Graaff
    Hans de Graaff

    I've verified that this got fixed in dbbf2fd19c012f68865f797395fdb7191d00dc68

    October 11th, 2010 @ 07:17 PM

  3. Jeff Kreeftmeijer
    Jeff Kreeftmeijer
    • State changed from invalid to resolved

    Awesome. Marking this as resolved. Bedankt Hans! ;)

    October 11th, 2010 @ 07:51 PM