Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

before_validation callback affected by rollback if validation failed

#5556

When I tryed to do some actions that interact with database in before_validation callback - they were rollback if validation failed.

Simple code to demonstrate examle:

class Message < ActiveRecord::Base
end

class PersistentCallbackDeveloper < ActiveRecord::Base

  set_table_name 'developers'

  validates_presence_of :name

  before_validation do 
    Message.create!(:body => "Validating #{self.inspect}")
  end

end

And the test:

def test_persistent_callbacks
  assert !PersistentCallbackDeveloper.create
  assert Message.exists?
end

The second assertion fail.

I think this is not correct: before and after validation callbacks should not be a part of transaction around save.

What do you think?

Thanks,
Bogdan.

Reported by Bogdan Gusiev · September 5th, 2010 @ 12:06 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Bogdan Gusiev
  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:48 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:48 PM