Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Add db:charset task support for PostgreSQL

#556

The db:charset tasks works only with MySQL.

This ticket modifies the PostgreSQL connection adapter adding support for obtaining the database encoding

Reported by Sebastian A. Espindola · July 6th, 2008 @ 11:31 PM

State: resolved
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Tarmo Tänav
    Tarmo Tänav
    • Tag changed from activerecord to activerecord, patch

    Solid patch, but there are a couple of minor complains. Firstly, it would be nice to format the SQL consistently, so "SELECT", "FROM", "WHERE" should all be capitalized. And secondly, please don't add empty lines and trailing whitespace (git should also warn about it).

    +1 if those two are adressed

    July 7th, 2008 @ 01:21 AM

  2. Sebastian A. Espindola
  3. Sebastian A. Espindola
    Sebastian A. Espindola
    • Tag changed from activerecord to activerecord, patch

    Done. I've uppercased all the SQL commands and eliminated the unnecesary newlines.

    New patch uploaded.

    Thanks.

    July 8th, 2008 @ 05:20 AM

  4. Repository
    Repository
    • State changed from new to resolved

    (from [0176e6adb388998414083e99523de318d3b8ca49]) Added db:charset support to PostgreSQL. [#556 state:resolved]

    Signed-off-by: Pratik Naik

    http://github.com/rails/rails/co...

    July 14th, 2008 @ 04:13 AM