This project is archived and is in readonly mode.
Add db:charset task support for PostgreSQL
-
Tarmo Tänav
- Tag changed from activerecord to activerecord, patch
Solid patch, but there are a couple of minor complains. Firstly, it would be nice to format the SQL consistently, so "SELECT", "FROM", "WHERE" should all be capitalized. And secondly, please don't add empty lines and trailing whitespace (git should also warn about it).
+1 if those two are adressed
-
Sebastian A. Espindola
- Tag changed from activerecord to activerecord, patch
Done. I've uppercased all the SQL commands and eliminated the unnecesary newlines.
New patch uploaded.
Thanks.
-
Repository
- State changed from new to resolved
(from [0176e6adb388998414083e99523de318d3b8ca49]) Added db:charset support to PostgreSQL. [#556 state:resolved]
Signed-off-by: Pratik Naik
