Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

model.validate is dropped if the same validator-method is used twice

#5561

When having multiple calls to validate (with different conditions) only one is used.

  class Topic
    include ActiveModel::Validations
    include ActiveModel::Validations::Callbacks

    Topic.validate :forbid_swearing, :on => :create
    Topic.validate :forbid_swearing, :on => :update, :unless => :approved

    def forbid_swearing
      # ...
    end
  end

validate_quota won't be called on creation (Post.new.valid?(:create)).

The following test can be added to the #activemodel@ test set, to demonstrate that behavior:

  def test_multiple_validators_with_same_name
    Topic.class_eval do
      def forbid_swearing
        if title and title.include?("bad")
          errors.add("title", "must not contain swearing")
        end
      end
    end
    
    Topic.validate :forbid_swearing, :on => :create
    Topic.validate :forbid_swearing, :on => :update, :unless => :approved
    
    t = Topic.new(:title => "bad")
    assert t.invalid?(:create)
    assert t.invalid?(:update)
    
    t.approved = true
    assert t.invalid?(:create)
    assert t.valid?(:update)
  end

Now there are workarounds for this issue. Since the validators heavily rely on ActiveSupports callback implementation I don't think it makes much sense to it.

But a clear warning or exception would have made my debug-session a lot easier.

Reported by Deleted User · September 6th, 2010 @ 05:38 AM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Tag changed from rails 3.0, activemodel, validate to rails 30, activemodel, validate

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:32 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:32 PM