Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Swap conditional order for better readability

#5618

"if X else Y" constructs are generally easier to read than "unless Y else X" constructs.

Reported by Wincent Colaiuta · September 12th, 2010 @ 12:37 AM

State: stale
Milestone: none
Assigned to: nobody
Importance: Low

Activity

  1. Jeff Kreeftmeijer
    Jeff Kreeftmeijer

    +1

    Great one. I hate it when stuff like that happens. :)

    September 12th, 2010 @ 10:40 AM

  2. Anil Wadghule
  3. Jeff Kreeftmeijer
    Jeff Kreeftmeijer
    • State changed from new to open
    • Tag set to action_view, patch
    • Importance changed from to Low

    October 10th, 2010 @ 09:16 AM

  4. Jeff Kreeftmeijer
    Jeff Kreeftmeijer
    • Title changed from [PATCH] Swap conditional order for better readability to Swap conditional order for better readability

    October 10th, 2010 @ 09:20 AM

  5. Santiago Pastorino
    Santiago Pastorino

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:30 PM

  6. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:30 PM