Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Wrong references in the comments of AS::Dependencies pointing to watch_modules

#5620

I've just found out on active_support/dependencies.rb that many comments were referencing watch_modules (which doesn't exists) instead of watch_namespaces (which I guess is the intended one, while studying the code)

Reported by Marcelo Giorgi · September 12th, 2010 @ 04:20 PM

State: resolved
Milestone: none
Assigned to: Yehuda Katz (wycats) Yehuda Katz (wycats)
Importance: Low

Activity

  1. Marcelo Giorgi
    Marcelo Giorgi
    • Assigned user set to Yehuda Katz (wycats)

    Here I attach a patch to make those reference point to watch_namespaces

    September 12th, 2010 @ 04:25 PM

  2. Marcelo Giorgi
  3. Rohit Arondekar
    Rohit Arondekar
    • Importance changed from to Low

    Marcelo, you can make changes to the API docs and Guides your self. The repo is http://github.com/lifo/docrails it has public write access so you can make the changes there. The changes will be pulled into the Rails repo later.

    Please do update this ticket so that I can close it, once you have made the changes.

    September 13th, 2010 @ 02:01 AM

  4. Marcelo Giorgi
    Marcelo Giorgi

    You can close it now, I've just update the references on http://github.com/lifo/docrails.

    Just a quick note, some of this wrong references in those comments are present within the implementation of some methods. That's why I wrote that patch for Rails itself, because I wasn't sure if this kind of comments were merged into the Rails repo...

    September 13th, 2010 @ 10:05 PM

  5. Rohit Arondekar
    Rohit Arondekar
    • State changed from new to resolved

    Thanks! :)

    And as long as you don't modify the code it's cool. :)

    Commit ref: http://github.com/lifo/docrails/commit/d5ef502d2a7968957376db453177...

    September 14th, 2010 @ 04:22 AM

  6. Andrea Campi
    Andrea Campi
    • Tag changed from patched to patch

    bulk tags cleanup

    October 11th, 2010 @ 07:24 AM

  7. Ryan Bigg
    Ryan Bigg
    • Tag cleared.

    Automatic cleanup of spam.

    October 11th, 2010 @ 12:14 PM