#5620 Wrong references in the comments of AS::Dependencies pointing to watch_modules - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5620 ✓resolved

Wrong references in the comments of AS::Dependencies pointing to watch_modules

Reported by Marcelo Giorgi | September 12th, 2010 @ 04:20 PM

I've just found out on active_support/dependencies.rb that many comments were referencing watch_modules (which doesn't exists) instead of watch_namespaces (which I guess is the intended one, while studying the code)

Comments and changes to this ticket

You flagged this item as spam.
Marcelo Giorgi September 12th, 2010 @ 04:25 PM
- Assigned user set to “Yehuda Katz (wycats)”
Here I attach a patch to make those reference point to watch_namespaces
- reference-watch_namespaces-in-comments-instead-of-watch_modules.patch 1.6 KB
You flagged this item as spam.
Marcelo Giorgi September 12th, 2010 @ 04:29 PM
- Tag set to “patched”
Rohit Arondekar September 13th, 2010 @ 02:01 AM
- Importance changed from “” to “Low”
Marcelo, you can make changes to the API docs and Guides your self. The repo is http://github.com/lifo/docrails it has public write access so you can make the changes there. The changes will be pulled into the Rails repo later.

Please do update this ticket so that I can close it, once you have made the changes.
You flagged this item as spam.
Marcelo Giorgi September 13th, 2010 @ 10:05 PM
You can close it now, I've just update the references on http://github.com/lifo/docrails.

Just a quick note, some of this wrong references in those comments are present within the implementation of some methods. That's why I wrote that patch for Rails itself, because I wasn't sure if this kind of comments were merged into the Rails repo...
Rohit Arondekar September 14th, 2010 @ 04:22 AM
- State changed from “new” to “resolved”
Thanks! :)

And as long as you don't modify the code it's cool. :)

Commit ref: http://github.com/lifo/docrails/commit/d5ef502d2a7968957376db453177...
You flagged this item as spam.
Andrea Campi October 11th, 2010 @ 07:24 AM
- Tag changed from “patched” to “patch”
bulk tags cleanup
Ryan Bigg October 11th, 2010 @ 12:14 PM
- Tag cleared.
Automatic cleanup of spam.
You flagged this item as spam.
klkk May 23rd, 2011 @ 02:32 AM
"comments"site:rails.lighthouseapp.com
You flagged this item as spam.
klkk May 23rd, 2011 @ 02:37 AM
It’s well known that our Louis Vuitton Outlet enjoys a good reputation