This project is archived and is in readonly mode.
[PATCH] Make redirect_to support blocks.
-
Nando Vieira
- Title changed from Make return_to support blocks. to [PATCH] Make return_to support blocks.
- Tag changed from block, redirection, redirect_to to actioncontroller, block, patch, redirection, redirect_to
-
Nando Vieira
- Title changed from [PATCH] Make return_to support blocks. to [PATCH] Make redirect_to support blocks.
-
Rohit Arondekar
- State changed from new to open
- Importance changed from to Low
Opening ticket to get more eyes on this.
-
José Valim
- Milestone set to 3.1
Do we really need to use instance_eval?
And Nando, could you please generate the patch using git format-patch? This way it will keep you as the author. -
Nando Vieira
Hey Rockstar! I thought of yielding the controller instance, but we often have private methods and instance variables, so
instance_evalmakes more sense, I think.The new patch is attached.
-
Repository
- State changed from open to resolved
(from [7223fe7faf26f717aee056942aadecc62e8f5cd9]) Make redirect_to accept blocks [#5643 [PATCH] Make redirect_to support blocks. state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/7223fe7faf26f717aee056942aadec...
