Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Full error messages on nested attributes do not work with I18n

#5666

Having the I18n model and attribute options set, the 'full_messages' method constructs the nested attribute names from calling 'humanize' on a string that is derived from replacing '.' by '_' in the attribute name, instead of rendering the name of the model and attribute by using model_name.human respectively human_attribute_name.

My patch splits the 'model.attribute' string in two, constantizing the 'model' string and checks if model_name can be called on the resulting class, then calling model_name.human and human_attribute_name(attribute_name) to construct the name to display.

Test are included. Patch applies to 3.1.0.beta and 3.0.0.

Reported by Anton Bangratz · September 20th, 2010 @ 08:54 AM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Tag changed from nested attributes, validations full message, 3.x to nested attributes, validations full message, 3x

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:31 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:31 PM