#5669 Setting session and cookie variables in same request breaks session in following request in Rails 2.3.9 - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5669 ✓committed

Setting session and cookie variables in same request breaks session in following request in Rails 2.3.9

Reported by omarqureshi | September 20th, 2010 @ 12:20 PM

The problem is the same in that a newline is appended to the _session_id key and is thus causing the next request to create a new session.

Weirdly though I have not been able to replicate in a real application, but, only as part of IntegrationTest.

You flagged this item as spam.
omarqureshi September 21st, 2010 @ 07:46 PM
Actually I lied, I did end up suffering from this in a real application just today.
You flagged this item as spam.
omarqureshi September 21st, 2010 @ 07:55 PM
Attached is the previous test with a patch
- active_record_store_session_cookie_test_and_patch.patch 1.8 KB
You flagged this item as spam.
omarqureshi September 27th, 2010 @ 09:25 AM
- Tag changed from “rails 2.3.9, active_record_store, cookies, sessions” to “rails 2.3.9, active_record_store, cookies, patch, sessions”
You flagged this item as spam.
omarqureshi October 11th, 2010 @ 12:46 PM
This time updated with a properly formatted patch
- active_record_store_session_cookie_test_and_patch.patch 2.3 KB
You flagged this item as spam.
sds October 21st, 2010 @ 12:57 PM
- Tag changed from “rails 2.3.9, active_record_store, cookies, patch, sessions” to “rails 2.3.10, rails 2.3.9, active_record_store, cookies, patch, sessions”
+1 for this fix. The issue still exists in 2.3.10.

And not just for Active Record session store.
Aaron Patterson October 21st, 2010 @ 06:31 PM
- State changed from “new” to “committed”
- Importance changed from “” to “Low”
I've applied this to the 2-3-stable branch. Thanks!
You flagged this item as spam.
omarqureshi October 22nd, 2010 @ 06:17 PM
Awesome - thank you!

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>