This project is archived and is in readonly mode.

#5691 ✓stale
Graeme Walters

:joins is ignored in a find within an habtm association extension

Reported by Graeme Walters | September 23rd, 2010 @ 04:58 PM

I've added some stuff to /web/rails/activerecord/test/cases/associations/habtm_join_table_test.rb

I've attached a full diff, but here's the interesting bit.

class MyReader < ActiveRecord::Base                                                                                                                   
  has_and_belongs_to_many :my_books do                                                                                                                
    def unreviewed_books                                                                                                                              
      :joins => "left join my_book_reviews on my_books.my_book_id = my_book_reviews.my_book_id",                                                      
      :conditions => "my_book_reviews.my_book_id is null")                                                                                            

When the unreviewed_books function is called, a query is built that incorporates the :conditions, but not the :joins -

SELECT * FROM "my_books" INNER JOIN "my_books_my_readers" ON "my_books".id = "my_books_my_readers".my_book_id WHERE ("my_books_my_readers".my_reader_id = 1 AND (my_book_reviews.my_book_id is null))

Which then fails with missing FROM-clause entry for table "my_book_reviews"

Anyone else come across this or have any ideas?

Comments and changes to this ticket

  • gnufied

    gnufied September 26th, 2010 @ 04:43 AM

    • Tag set to needs_more_info

    Please submit a new patch which can be applied against master. Also correct place to add these tests is "has_and_belongs_to_many_associations_test.rb".

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:59 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:59 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket