Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• 

  Pratik July 8th, 2008 @ 01:08 PM

  • State changed from “new” to “incomplete”

  Could you please add a failing test case to your patch ?

  Thanks.

• You flagged this item as spam.
  

  tmtysk July 8th, 2008 @ 03:56 PM

  Hi, Pratik.

  I don't know how to write a test-case for Dispatcher, but I could confirm a failing case by following procedures below.

  1) Set using MemCacheStore as SessionStorage.

  2) Start rails application by 'script/server -p3000'

  3) Run a following rspec examples:

  describe "ActionController::Dispatcher" do

  it "should render a text in '/public/500.html' when specified invalid session_id" do

  `curl "http://localhost:3000/?_sess='"`.include?("We're sorry, but something went wrong (500)").should be_true

  end

  end

  Before patched, Dispatcher could NOT get '500.html' as error_path, got '500 .html', so it failed test case.

  Thanks.

• You flagged this item as spam.
  

  Kieran P July 23rd, 2008 @ 10:59 PM

  We've encountered this problem ourselves. After a little research, a ticket relating to this problem was found on the old bug tracker. See

  http://dev.rubyonrails.org/ticke...

  Basically, its looking for '500 .html' rather than '500.html'. Changing [0..3] to [0...3] has fixed the problem.

• 

  CancelProfileIsBroken August 3rd, 2009 @ 03:01 PM

  • Tag changed from “2.0-stable, 2.1, actionpack, bug, dispatcher, edge, patch” to “2.0-stable, 2.1, actionpack, bug, bugmash, dispatcher, edge, patch”

• You flagged this item as spam.
  

  Cristi Balan August 8th, 2009 @ 04:05 PM

  not reproducible

  Patch does not apply and looking at the dispatcher tests, there already seems to be a test for this behaviour:

  http://github.com/rails/rails/blob/9aaeb18781f329bf04c3174898bb8f32...

• You flagged this item as spam.
  

  Kieran P August 8th, 2009 @ 10:12 PM

  • Tag changed from “2.0-stable, 2.1, actionpack, bug, bugmash, dispatcher, edge, patch” to “2.0-stable, 2.1, actionpack, bug, bugmash, dispatcher, edge, patch, resolved”

  This bug is no longer an issue (was fixed in a 2.1.x release IIRC).

  Also, 2-3-stable no longer uses the same code anyway (http://github.com/rails/rails/blob/2-3-stable/actionpack/lib/action....

  Someone can probably close this ticket now.

• 

  CancelProfileIsBroken August 8th, 2009 @ 10:22 PM

  • State changed from “incomplete” to “resolved”
  • Tag changed from “2.0-stable, 2.1, actionpack, bug, bugmash, dispatcher, edge, patch, resolved” to “2.0-stable, 2.1, actionpack, bug, dispatcher, edge, patch, resolved”