Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

exception_notification fails with rails 3.1beta

#5701

The mentioned plugin fails in AbstractController line 54 (http://github.com/rails/rails/blob/master/actionpack/lib/abstract_c...) because controller.respond_to?(:routes) is true, but controller.routes is nil.

I'm not sure if this is a big in the plugin or the condition in AbstractController should check for controller._routes too.

When I add the controller._routes condition, the plugin works fine.

Reported by gucki · September 25th, 2010 @ 01:00 AM

State: resolved
Milestone: none
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. gucki
    gucki

    September 25th, 2010 @ 01:05 AM

  2. Ryan Bigg
    Ryan Bigg
    • State changed from new to incomplete
    • Importance changed from to Low

    Please add steps to reproduce this issue and/or a patch to fix it.

    September 27th, 2010 @ 11:20 PM

  3. gucki
    gucki

    To reproduce just create a new rails app, add the exception notification middleware and raise an exception in any action.

    Patch is already attached (see above).

    September 30th, 2010 @ 01:32 PM

  4. gucki
    gucki

    The link above seems outdated, here's the patch again:
    http://github.com/gucki/rails/commit/337ea1900827ef42696093a175ee7a...

    September 30th, 2010 @ 01:33 PM

  5. gucki
    gucki
    • Assigned user set to José Valim

    This bug can be closed now, as it's been resolved by this commit:
    http://github.com/rails/rails/commit/8f9e9118e402ea2fe1eec6fcb9a2d3...

    October 8th, 2010 @ 12:10 PM

  6. Rohit Arondekar
    Rohit Arondekar
    • State changed from incomplete to resolved

    October 8th, 2010 @ 12:33 PM