This project is archived and is in readonly mode.

Add magic encoding comment to generated files

#5759

rails g mailer 'absence/request_mailer' pending

generates such code:

 class Absence::RequestMailer < ActionMailer::Base
  default :from => "from@example.com"

  # Subject can be set in your I18n file at config/locales/en.yml
  # with the following lookup:
  #
  #   en.request_mailer.new.subject
  #
  def pending
    @greeting = "Hi"

    mail :to => "rpa@gavdi.com"
  end

end

The lookup in the comment is invalid in such case. It should be:

en.absence.request_mailer.new.subject

Reported by Robert Pankowecki · October 5th, 2010 @ 02:30 PM

Activity

Aditya Sanghi
- Assigned user set to Mikel Lindsaar
- Tag changed from autogenerated, comment, mailer, rails3 to autogenerated, comment, mailer, patch, rails3
This patch should solve the problem i believe. I couldn't find any tests to test the mailer generator however.
- mailer_namespaced_model.diff 964 Bytes
October 5th, 2010 @ 04:34 PM
Robert Pankowecki
Wow, that was quick fix :-)

October 5th, 2010 @ 10:59 PM
Ryan Bigg
- State changed from new to open
- Importance changed from to Low
The generators are in railties/test/generators. Please add a new test class for this in the mailer_generator.rb test file, using the arguments you have passed in to your test-run.

October 5th, 2010 @ 11:51 PM
Ryan Bigg
- Tag changed from autogenerated, comment, mailer, patch, rails3 to mailer, rails3
October 5th, 2010 @ 11:52 PM
Aditya Sanghi
Thanks for the tip Ryan. I've added a test method in the mailer_generator.rb for checking namespaced mailers. Updated the patch.

October 6th, 2010 @ 07:44 AM
Aditya Sanghi
Thanks for the tip Ryan. I've added a test method in the mailer_generator.rb for checking namespaced mailers. Updated the patch.
- mailer_namespaced_model_with_test.diff 3.04 KB
October 6th, 2010 @ 07:45 AM
Mikel Lindsaar
Nice checked it out and applying now.

October 6th, 2010 @ 09:29 AM
Mikel Lindsaar
- Milestone cleared.
October 6th, 2010 @ 09:30 AM
Mikel Lindsaar
- State changed from open to committed
Thanks for your work. I also pushed your changes to master. I merged the last two patches to increase the SNR.

October 6th, 2010 @ 09:45 AM
Aditya Sanghi
Thanks Mikel,

I'm still a git white belt. I wonder how one can merge 2 commits into one? ..And i know what SNR stands for too now.

October 6th, 2010 @ 09:58 AM
Mikel Lindsaar
Some git master I am sure could teach you, you can squash commits apparently :)

All I did was manually edit the second patch and voila :)

October 6th, 2010 @ 10:10 AM
Ryan Bigg
- Tag cleared.
Automatic cleanup of spam.

October 9th, 2010 @ 10:04 PM
Jeremy Kemper
- Milestone set to 3.0.2
[bulk edit]

October 15th, 2010 @ 11:02 PM
Ryan Bigg
Automatic cleanup of spam.

October 21st, 2010 @ 03:39 AM
Jeff Kreeftmeijer
Automatic cleanup of spam.

October 24th, 2010 @ 01:09 PM
Robert Pankowecki
When did the name of the bug changed from "invalid comment generated for namespaced-mailer" ? :-)

November 22nd, 2010 @ 04:17 PM
bingbing
luxury watch

March 26th, 2011 @ 01:16 AM
bingbing
luxury watch

March 26th, 2011 @ 01:17 AM
bingbing
gucci watches

March 26th, 2011 @ 01:20 AM
links london
links of london

April 1st, 2011 @ 09:26 AM
juicy
The weather becomes night, a little cool, sat in the room, still open, fan, the wind makes me feel less than that of static terrible night. Don't care about is blown dry ice, is the heart of ice, also.

April 10th, 2011 @ 09:40 AM
sadie
The weather becomes night, a little cool, sat in the room, still open, fan, the wind makes me feel less than that of static terrible night. Don't care about is blown dry ice, is the heart of ice, also. Newspaper articles

April 18th, 2011 @ 12:47 PM