This project is archived and is in readonly mode.
field_set_tag should take an options hash
-
Donald Piret
Shouldn't that be:
module ActionView
module Helpers
module FormTagHelper
def field_set_tag(legend = nil, options={}, &block)
content = capture(&block)
concat(tag(:fieldset, options, true), block.binding)
concat(content_tag(:legend, legend), block.binding) unless legend.blank?
concat(content, block.binding)
concat("", block.binding)
end
end
end
end
-
2 College Bums
Good catch. However you need a closing fieldset tag
def field_set_tag(legend = nil, options={}, &block) content = capture(&block) concat(tag(:fieldset, options, true), block.binding) concat(content_tag(:legend, legend), block.binding) unless legend.blank? concat(content, block.binding) concat("</fieldset>", block.binding) end -
josh
- State changed from new to wontfix
-
2 College Bums
- Assigned user set to josh
Hey Joshua,
Thanks for reviewing our ticket. May we ask the rationale for not allowing an options hash for the fieldset tag?
Thanks!
-
Tom Stuart
Here's the rationale: http://github.com/rails/rails/co...>