This project is archived and is in readonly mode.
typo in abstract_renderer?
-
Aditya Sanghi- State changed from new to open
- Milestone set to 3.0.2
- Tag changed from abstract_renderer, action_view to abstract_renderer, action_view, patch
- Importance changed from to Low
yup you're right, it should be :view not :vew.
Attaching patch.
-
Jeff Kreeftmeijer
Aw, you beat me to it. Submitting my patch anyway to provide some tests. Since I wasn't sure where to test this, I created
actionpack/test/abstract/renderer_test.rb. Any thoughts? :)-
5819.diff
1.68 KB
-
-
Aditya Sanghi
@jeff, test looks fine.
Deleting my patch, no worries! :)
-
José ValimActually, it seems nobody is using that. we can simply remove it.
-
Jeff Kreeftmeijer
The whole
attr_readerpart or just the:viewreader? I'll yank it out. :) -
José Valim
If you remove all and tests still pass, remove it all. :)
-
Jeff Kreeftmeijer
Removing the whole thing caused a bunch of test fails, so I just removed the
:vewattr_reader. Tests still pass. :)-
5819.diff
960 Bytes
-
-
Repository
- State changed from open to resolved
(from [b454bb0a98e3557ad974a93828c3951bce0ac81c]) Remove the :vew attr_reader from ActionView::AbstractRenderer [#5819 typo in abstract_renderer? state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/b454bb0a98e3557ad974a93828c395...