This project is archived and is in readonly mode.
typo in abstract_renderer?
Reported by Jan Xie | October 16th, 2010 @ 04:15 AM | in 3.0.2
http://github.com/rails/rails/blob/master/actionpack/lib/action_vie...
:vew should be :view?
Comments and changes to this ticket
-
Aditya Sanghi October 16th, 2010 @ 09:03 AM
- State changed from “new” to “open”
- Milestone set to “3.0.2”
- Tag changed from “abstract_renderer, action_view” to “abstract_renderer, action_view, patch”
- Importance changed from “” to “Low”
yup you're right, it should be :view not :vew.
Attaching patch.
-
Jeff Kreeftmeijer October 16th, 2010 @ 09:33 AM
Aw, you beat me to it. Submitting my patch anyway to provide some tests. Since I wasn't sure where to test this, I created
actionpack/test/abstract/renderer_test.rb. Any thoughts? :) -
Aditya Sanghi October 16th, 2010 @ 09:39 AM
@jeff, test looks fine.
Deleting my patch, no worries! :)
-
José Valim October 16th, 2010 @ 09:42 AM
Actually, it seems nobody is using that. we can simply remove it.
-
Jeff Kreeftmeijer October 16th, 2010 @ 10:23 AM
The whole
attr_readerpart or just the:viewreader? I'll yank it out. :) -
-
Jeff Kreeftmeijer October 16th, 2010 @ 10:40 AM
Removing the whole thing caused a bunch of test fails, so I just removed the
:vewattr_reader. Tests still pass. :) -
Repository October 16th, 2010 @ 05:17 PM
- State changed from “open” to “resolved”
(from [b454bb0a98e3557ad974a93828c3951bce0ac81c]) Remove the :vew attr_reader from ActionView::AbstractRenderer [#5819 state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/b454bb0a98e3557ad974a93828c395...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Aditya Sanghi
Jan Xie
Jeremy Kemper
José Valim
Attachments
Referenced by
-
5819
typo in abstract_renderer?
(from [b454bb0a98e3557ad974a93828c3951bce0ac81c])
Remove ...