This project is archived and is in readonly mode.
Configurables needed in Rails::Engine and Rails:Application?
Not sure whether configurables are needed both in Rails::Engine and Rails:Application. Do they just stay there for consistency to Rails:Railties? There are no source files such as railties/lib/rails/engine/configurable.rb or railties/lib/rails/application/configurable.rb anyways.
Also it seems including railties_path to load path in cli.rb is unnecessary because bin/rails already does that. Maybe it's just because it would avoid dependency in case someone would reuse cli.rb?
-
remove_unused_lines_patch.diff
1.93 KB
-
Piotr Sarnacki- Assigned user set to José Valim
You're right, they are no longer needed, railtie/configurable is used for all those classes.
-
-
Repository
- State changed from new to resolved
(from [8a6ac4fc26bacbd2a6c978cace156e300b77508e]) Remove unused Configurable in Rails::Engine and Rails::Application. Remove unnecessary railties load path in cli [#5871 Configurables needed in Rails::Engine and Rails:Application? state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
https://github.com/rails/rails/commit/8a6ac4fc26bacbd2a6c978cace156...