This project is archived and is in readonly mode.
Configurables needed in Rails::Engine and Rails:Application?
Reported by zjia | October 27th, 2010 @ 04:58 AM
Not sure whether configurables are needed both in Rails::Engine and Rails:Application. Do they just stay there for consistency to Rails:Railties? There are no source files such as railties/lib/rails/engine/configurable.rb or railties/lib/rails/application/configurable.rb anyways.
Also it seems including railties_path to load path in cli.rb is unnecessary because bin/rails already does that. Maybe it's just because it would avoid dependency in case someone would reuse cli.rb?
Comments and changes to this ticket
-
Piotr Sarnacki October 28th, 2010 @ 12:02 PM
- Assigned user set to José Valim
You're right, they are no longer needed, railtie/configurable is used for all those classes.
-
Jeff Kreeftmeijer November 1st, 2010 @ 05:05 PM
- Importance changed from to Low
Automatic cleanup of spam.
-
Repository November 11th, 2010 @ 04:30 PM
- State changed from new to resolved
(from [8a6ac4fc26bacbd2a6c978cace156e300b77508e]) Remove unused Configurable in Rails::Engine and Rails::Application. Remove unnecessary railties load path in cli [#5871 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
https://github.com/rails/rails/commit/8a6ac4fc26bacbd2a6c978cace156...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Referenced by
- 5871 Configurables needed in Rails::Engine and Rails:Application? (from [8a6ac4fc26bacbd2a6c978cace156e300b77508e]) Remove ...