Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

optimize javascript_include_tag to skip duplicate sources

#5876

When you have defined multiple javascript expansions with perhaps some common sources, at the end, you can have multiple script-tags to the same sources, which is unnecessary.

This patch includes a change where an extra option (:unique, false by default) is added to the javascript_include_tag method.

When you specify :unique => true, any duplicate source will be removed.

Reported by Christiaan Van den Poel · October 28th, 2010 @ 02:07 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Christiaan Van den Poel
    Christiaan Van den Poel

    attached patch

    notice that this patch still requires to specify :unique => true explicitly.

    October 28th, 2010 @ 02:12 PM

  2. Christiaan Van den Poel
    Christiaan Van den Poel

    attached my second patch where this behavior is now default.

    I'd like to note this could break existing applications.

    October 30th, 2010 @ 08:35 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:21 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:21 PM

  5. bingbing