Paragraphed anchors and notice layout in generators

Hi Pratik,

The idea of making the changes was to help the rails developer starting off on the right foot. Unobtrusive CSS, well formatted HTML etc, etc.

Having the notice auto generate a paragraph if present is a good for learning, surly?

styles.css doesn't get "generated" in their public directory but scaffold.css doesn't it?

When people upgrade Rails adding a bit of CSS wouldn't be that big of an issue since environments/initialisers have been known to change between updates. I'd imagine mature rails projects will have it's own CSS for notices anyway. But since I would imaging scaffolding would be used primarily at the beginning of a project anyway this wouldn't be a big problem.

Or am I missing something :S ?

I want to support this one. Yes, it is a learning tool and not to be used in production but that why it's a even more important to make sure its not full of nasty markup and inline CSS. Rails is promoting best practices right? I don't think the style.css/upgrade issue is anywhere near enough of a problem to can this and the markup stuff is very worth putting in.

For what it's worth, I'd give this a +1.

"I don't really see much value in this patch."

I don't see much justification for knowingly generating bad markup.

Also, I think the following :

<% if flash[:notice].present? %>
  <p style="color: green"><%%= flash[:notice] %></p>
<% end %>

is better than :

<%%= content_tag(:p, flash[:notice],:id => "notice") unless flash[:notice].blank? %>

(from [5096ba961c49e5b419c3400acd7c87373a36d6d4]) Remove inline css. [#593 Paragraphed anchors and notice layout in generators status:resolved] http://github.com/rails/rails/commit/5096ba961c49e5b419c3400acd7c87...