This project is archived and is in readonly mode.
application.js is added twice when :defaults expansion is redefined
-
zaki
- Tag changed from javascript_expansions, javascript_include_tag to javascript_expansions, javascript_include_tag, patch
-
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
-
Josh Kalderimis
- State changed from stale to open
- Tag changed from javascript_expansions, javascript_include_tag, patch to actionpack, asset_tag_helper
After talking to José about this, it seems the solution to the issue requires a bit of a reworking.
I am currently working on a patch which will take care of this issue but also other issues found when reading into the tests, the main problem being that
javascript_include_tagallows for duplicate asset tags, which is the root cause of this issue.Ticket reopened and patch on its way.
[state:open]
-
Josh Kalderimis
- Assigned user set to Santiago Pastorino
This issue can now be closed as it is resolved by https://github.com/rails/rails/commit/1363bb8f7215fadb65e9296217be2... in master.
-
rails
- State changed from open to committed
- Importance changed from to Low
