Rails Ruby on Rails

Comments and changes to this ticket

• 

  Andrew White November 17th, 2010 @ 05:49 PM

  • State changed from “new” to “invalid”
  • Importance changed from “” to “Low”

  Functional tests call the controller action directly and don't go through the router. Use an ActionDispatch::IntegrationTest to check the routing constraints. e.g:

    rails generate test_unit:integration my_controller_routing
  

• You flagged this item as spam.
  

  Fernando Guillen November 17th, 2010 @ 08:09 PM

  But then what is the propose of having the five verbs in the ActionController::TestCase if I can use any of them without any restriction or diference?

  It is not intuitive.

  And besides the ActionController::TestCase, some way, looks to the defined routes because if don't have the route defined on your routes.rb it raises an ActionController::RoutingError.

• 

  Andrew White November 18th, 2010 @ 07:05 AM

  The get, post, etc. methods are just wrappers around the process method of ActionController::TestCase. All they do is set the REQUEST_METHOD header in the Rack environment so that any code in your controller that is dependent on the request method acts appropriately, e.g.

    # routes.rb
    match '/basket', :to => 'shop#basket', :via => [:get, :post]
  
    # app/controllers/shop_controller.rb
    class ShopController < ApplicationController
      before_filter :load_basket
  
      def basket
        @basket.update(params[:basket]) if request.post?
      end
  
      protected
        def load_basket
          @basket = Basket.new(session[:basket])
        end
    end
  

  The routing error you get is because the process method builds a request uri so it's a generation error and not a recognition error (generation of urls ignores HTTP verbs as well).

  Functional tests are meant to be isolated tests of your controller - if you need to test the full stack use an integration test.

• You flagged this item as spam.
  

  Fernando Guillen November 18th, 2010 @ 09:58 AM

  Ok, I understand pretty much better all this behavior.

  So the verbs in the ActionController::TestCase are just to mark this request with this REQUEST_METHOD header in order to be used (or not) in our Controller.

  And also I have realized that we are also checking that the url we are calling can be built based on our routes definition, but without taken care about the verbs restrictions. So it should be able to be generated but it doesn't need to be recognized.

  (This last point sounds a few inconsistent for me, but I understand I don't have the whole picture in my mind)

  Thanks for your explanation.

• 

  Andrew White November 18th, 2010 @ 10:29 AM

  That's pretty much it except the route is being built so that the REQUEST_URI header can be set and not to check whether the route can be generated (though it obviously it needs to be).