Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

current_page? bug with trailing slash in request url

#6033

If developer used current_page? helper from ActionView::Helpers::UrlHelper (if current_page?(:action => 'edit') for example) but user entered url WITH trailing slash - "somethings/1/edit/" (which is not corresponds to the rfc, but browsers allows do it) this method will return false. This situation makes current_page? helper useless because of developer have to write something like if params[:sction] == 'edit'...

Possible solution: add something like request_uri.gsub!(/\/$/, '') before request_uri and url_string comparsion if current_page? method

Reported by uzzz · November 22nd, 2010 @ 01:25 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. rails
    rails
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 23rd, 2011 @ 12:00 AM

  2. rails
    rails
    • State changed from open to stale

    February 23rd, 2011 @ 12:00 AM