This project is archived and is in readonly mode.
MysqlAdapter#column_exists? returns incorrect result when passing in :limit option
The #column_exists? method only checks for equality across all options which is incorrect in mysql since the limit depends on the column type (tinyint, smallint, mediumint, bigint, etc).
For example, the following column definition:
t.column :foo, :integer, :limit => 11
should return true when asking if the column exists but doesn't since MysqlColumn#extract_limit determines the limit based on the column type.
column_exists?(:test_table, :foo, :integer, :limit => 11) # false
-
Chris ConleyMoved #limit_exists? to Column and made sure we are only doing anything special for type "integer". Updated patch attached.
-
rails- State changed from new to open
- Tag changed from mysql adapter, migrations, rails3.0.3, schema to mysql adapter, migrations, rails303, schema
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails
- State changed from open to stale
-
Anuj Dutta- State changed from stale to open
This exists in the current master branch. Attempted to improve the attached patch. Improved version attached.
[state:open]
-
ticket-6049.patch
7.45 KB