This project is archived and is in readonly mode.
MysqlAdapter#column_exists? returns incorrect result when passing in :limit option
Reported by Chris Conley | November 23rd, 2010 @ 08:25 PM
The #column_exists? method only checks for equality across all options which is incorrect in mysql since the limit depends on the column type (tinyint, smallint, mediumint, bigint, etc).
For example, the following column definition:
t.column :foo, :integer, :limit => 11
should return true when asking if the column exists but doesn't since MysqlColumn#extract_limit determines the limit based on the column type.
column_exists?(:test_table, :foo, :integer, :limit => 11) # false
Comments and changes to this ticket
-
Chris Conley November 23rd, 2010 @ 09:22 PM
Moved #limit_exists? to Column and made sure we are only doing anything special for type "integer". Updated patch attached.
-
rails February 24th, 2011 @ 12:00 AM
- State changed from “new” to “open”
- Tag changed from “mysql adapter, migrations, rails3.0.3, schema” to “mysql adapter, migrations, rails303, schema”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails February 24th, 2011 @ 12:00 AM
- State changed from “open” to “stale”
-
Anuj Dutta March 2nd, 2011 @ 02:50 AM
- State changed from “stale” to “open”
This exists in the current master branch. Attempted to improve the attached patch. Improved version attached.
[state:open]
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Chris Conley