Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

app generator not including script.aculo.us with prototype

#6112

With the commit accepted in #5613 adding "-j" parameter for "rails new" command to add the --javascript and --skip_javascript options to the app generator, the wrong option is checked for when determining whether or not to include the script.aculo.us files when using Prototype (meaning this affects an app generated with default/no additional options).

The default javascript_expansions config expects these to be present, so they get included in the application layout and the log is littered with errors of no route matching the missing .js files.

The attached patch is a one-liner, plus tests. I've also submitted a pull request.

Reported by Ches Martin · December 3rd, 2010 @ 03:06 PM

State: resolved
Milestone: none
Assigned to: Santiago Pastorino Santiago Pastorino
Importance: Low

Activity

  1. Ches Martin
  2. siong1987
    siong1987
    • Assigned user set to Aaron Patterson

    Sorry. It was my mistake. +1 for this patch.

    December 8th, 2010 @ 10:06 PM

  3. siong1987
    siong1987
    • Assigned user changed from Aaron Patterson to Santiago Pastorino

    December 8th, 2010 @ 10:07 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to resolved
    • Assigned user changed from Santiago Pastorino to Sam Ruby
    • Importance changed from to Low

    Ches Martin, Piotr already fixed this :(.
    Thanks anyways for your patch.

    December 16th, 2010 @ 01:33 PM

  5. Santiago Pastorino
    Santiago Pastorino
    • Assigned user changed from Sam Ruby to Santiago Pastorino

    December 16th, 2010 @ 01:33 PM

  6. Piotr Sarnacki
    Piotr Sarnacki

    Ches: Oops, I totally forgot about your pull request and fixed it while I was doing other changes in app generator and plugin generator, sorry :) Now I have commit access, so I will be able to merge pull requests right away.

    December 16th, 2010 @ 03:15 PM

  7. Ches Martin
    Ches Martin

    No worries, so it goes with bugs that are smaller than the hassle it takes to process Lighthouse tickets. I'll get around to contributing something of more substance one of these days :-/

    Thanks guys.

    December 16th, 2010 @ 05:26 PM