Rails Ruby on Rails → 3.1

Comments and changes to this ticket

• 

  Mikel Lindsaar September 11th, 2010 @ 08:35 AM

  • Milestone set to “3.1”
  • Assigned user set to “Mikel Lindsaar”
  • Importance changed from “” to “Low”

  You should post this idea on the rails-core mailing list, get some +1's and verifs.

• You flagged this item as spam.
  

  siong1987 September 11th, 2010 @ 08:42 AM

  sorry. minor update.

  @Mikel: the post was there already: http://groups.google.com/group/rubyonrails-core/browse_thread/threa...

  • new_adding_j_parameter_for_rails_new_command_patch.diff 189.3 KB

• You flagged this item as spam.
  

  siong1987 September 13th, 2010 @ 07:56 PM

  better yet. minor change.

  • adding_j_parameter_for_rails_new_patch.diff 190 KB

• You flagged this item as spam.
  

  Victor Ng October 1st, 2010 @ 09:49 AM

  Great effort. I think most Web 2.0 websites today include jQuery as their default library.

• 

  Aditya Sanghi October 2nd, 2010 @ 08:12 PM

  +1 We

• 

  Aditya Sanghi October 2nd, 2010 @ 08:20 PM

  +1 We <3 jQuery. Way to go.

• 

  David Trasbo October 8th, 2010 @ 09:33 AM

  • State changed from “new” to “wontfix”

  The pull request (http://github.com/rails/rails/pull/16) has been closed. Marking this wontfix for now.

• You flagged this item as spam.
  

  siong1987 October 8th, 2010 @ 02:07 PM

  David,

  The pull request is closed because the core team wants me to get others in the core team to support this ticket. And, hence, I put up this ticket here.

  You might have to reopen this ticket so that others can look at this ticket.

• 

  Santiago Pastorino October 8th, 2010 @ 02:38 PM

  • State changed from “wontfix” to “open”
• 

  Santiago Pastorino October 11th, 2010 @ 08:20 PM

  • Assigned user changed from “Mikel Lindsaar” to “Santiago Pastorino”
• 

  Santiago Pastorino October 11th, 2010 @ 09:00 PM

  siong1987 I'd like to know what is your latest patch related to this and if it's rebased because I know there were one as a pull request. Thank you.

• You flagged this item as spam.
  

  siong1987 October 11th, 2010 @ 09:56 PM

  The patch(September 13th, 2010 @ 07:56 PM) I last submitted here should be the latest.

  The pull request might be a bit too old and it might not have the latest changes I made.

• 

  Santiago Pastorino October 11th, 2010 @ 10:03 PM

  Good siong1987 but one thing you're doing this

  +        copy_file "public/javascripts/#{@options[:javascript]}_ujs.js", "public/javascripts/rails.js"
  +        copy_file "public/javascripts/#{@options[:javascript]}_ujs.js", "public/javascripts/rails.js"
  

  twice

• You flagged this item as spam.
  

  siong1987 October 11th, 2010 @ 10:18 PM

  Oh shit. I totally missed that line. Do you want me to resubmit a new patch again?

• 

  Santiago Pastorino October 11th, 2010 @ 10:41 PM

  ok no problem i can fix it

• 

  Repository October 11th, 2010 @ 10:55 PM

  • State changed from “open” to “committed”

  (from [708e09448ba41c45f189c6b1adc989eba8994b20]) -j parameter added to rails new command.

  Now you can start your apps with jquery with rails new myapp -j jquery, the default is still prototype

  [#5613 state:committed]

  Signed-off-by: Santiago Pastorino santiago@wyeworks.com
  http://github.com/rails/rails/commit/708e09448ba41c45f189c6b1adc989...

• You flagged this item as spam.
  

  siong1987 October 11th, 2010 @ 11:00 PM

  cool. thanks.

• 

  Santiago Pastorino October 12th, 2010 @ 12:07 AM

  You're welcome and please keep helping.
  This issue was around since the discussion about ujs started.
  But this kind of stuff needs a deep discussion, so the patch you did was really helpful to make it easier the discussion.

• You flagged this item as spam.
  

  Ches Martin December 8th, 2010 @ 08:13 PM

  • Tag changed from “javascript, jquery, rails3.0.0” to “appgenerator, javascript, jquery, rails3.0.0”

  There's a small problem with this which I've addressed in #6112 -- if that passes review, may want to make sure the ticket is flagged for the same milestone as this one.