This project is archived and is in readonly mode.
adding "-j" parameter for "rails new" command
it seems like there are more and more people using "jquery" as the default javascript library when they start up a new rails app.
for this patch, i removed the usual "--skip-prototype" parameter and substituted it with the "--skip-javascript" parameter. then, i added a new "-j" or "--javascript" parameter. this parameter accepts either "jquery" or "prototype".
btw, the default javascript library now is still "prototype".
-
Mikel Lindsaar- Milestone set to 3.1
- Assigned user set to Mikel Lindsaar
- Importance changed from to Low
You should post this idea on the rails-core mailing list, get some +1's and verifs.
-
siong1987sorry. minor update.
@Mikel: the post was there already: http://groups.google.com/group/rubyonrails-core/browse_thread/threa...
-
-
Victor NgGreat effort. I think most Web 2.0 websites today include jQuery as their default library.
-
Aditya Sanghi
+1 We
-
Aditya Sanghi
+1 We <3 jQuery. Way to go.
-
David Trasbo- State changed from new to wontfix
The pull request (http://github.com/rails/rails/pull/16) has been closed. Marking this
wontfixfor now. -
siong1987
David,
The pull request is closed because the core team wants me to get others in the core team to support this ticket. And, hence, I put up this ticket here.
You might have to reopen this ticket so that others can look at this ticket.
-
Santiago Pastorino
- State changed from wontfix to open
-
Santiago Pastorino
- Assigned user changed from Mikel Lindsaar to Santiago Pastorino
-
Santiago Pastorino
siong1987 I'd like to know what is your latest patch related to this and if it's rebased because I know there were one as a pull request. Thank you.
-
siong1987
The patch(September 13th, 2010 @ 07:56 PM) I last submitted here should be the latest.
The pull request might be a bit too old and it might not have the latest changes I made.
-
Santiago Pastorino
Good siong1987 but one thing you're doing this
+ copy_file "public/javascripts/#{@options[:javascript]}_ujs.js", "public/javascripts/rails.js" + copy_file "public/javascripts/#{@options[:javascript]}_ujs.js", "public/javascripts/rails.js"twice
-
siong1987
Oh shit. I totally missed that line. Do you want me to resubmit a new patch again?
-
Santiago Pastorino
ok no problem i can fix it
-
Repository
- State changed from open to committed
(from [708e09448ba41c45f189c6b1adc989eba8994b20]) -j parameter added to rails new command.
Now you can start your apps with jquery with rails new myapp -j jquery, the default is still prototype
[#5613 adding "-j" parameter for "rails new" command state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/708e09448ba41c45f189c6b1adc989... -
siong1987
cool. thanks.
-
Santiago Pastorino
You're welcome and please keep helping.
This issue was around since the discussion about ujs started.
But this kind of stuff needs a deep discussion, so the patch you did was really helpful to make it easier the discussion. -
Ches Martin- Tag changed from javascript, jquery, rails3.0.0 to appgenerator, javascript, jquery, rails3.0.0
There's a small problem with this which I've addressed in #6112 app generator not including script.aculo.us with prototype -- if that passes review, may want to make sure the ticket is flagged for the same milestone as this one.