This project is archived and is in readonly mode.
app generator not including script.aculo.us with prototype
Reported by Ches Martin | December 3rd, 2010 @ 03:06 PM
With the
commit accepted in #5613 to add the --javascript
and
--skip_javascript
options to the app generator, the
wrong option is checked for when determining whether or not to
include the script.aculo.us files when using Prototype (meaning
this affects an app generated with default/no additional
options).
The
default javascript_expansions config expects these to be
present, so they get included in the application layout and the log
is littered with errors of no route matching the missing
.js
files.
The attached patch is a one-liner, plus tests. I've also submitted a pull request.
Comments and changes to this ticket
-
siong1987 December 8th, 2010 @ 10:06 PM
- Assigned user set to Aaron Patterson
Sorry. It was my mistake. +1 for this patch.
-
siong1987 December 8th, 2010 @ 10:07 PM
- Assigned user changed from Aaron Patterson to Santiago Pastorino
-
Santiago Pastorino December 16th, 2010 @ 01:33 PM
- State changed from new to resolved
- Assigned user changed from Santiago Pastorino to Sam Ruby
- Importance changed from to Low
Ches Martin, Piotr already fixed this :(.
Thanks anyways for your patch. -
Santiago Pastorino December 16th, 2010 @ 01:33 PM
- Assigned user changed from Sam Ruby to Santiago Pastorino
-
Piotr Sarnacki December 16th, 2010 @ 03:15 PM
Ches: Oops, I totally forgot about your pull request and fixed it while I was doing other changes in app generator and plugin generator, sorry :) Now I have commit access, so I will be able to merge pull requests right away.
-
Ches Martin December 16th, 2010 @ 05:26 PM
No worries, so it goes with bugs that are smaller than the hassle it takes to process Lighthouse tickets. I'll get around to contributing something of more substance one of these days :-/
Thanks guys.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 5613 adding "-j" parameter for "rails new" command There's a small problem with this which I've addressed in...