This project is archived and is in readonly mode.

#6122 ✓stale
Victor Lin

ActiveRecord::ConnectionAdapters::Column.string_to_time parses differently from 2.3.x

Reported by Victor Lin | December 6th, 2010 @ 11:57 PM

In rails 2 the following line returns a Time object:

Rails 3 returns nil due to this line:
# File activesupport/lib/active_support/core_ext/time/calculations.rb
29: time.year == year ? time : ::DateTime.civil_from_format(utc_or_local, year, month, day, hour, min, sec)

hour/min/sec are nil (since the string doesn't supply these values). This causes civil_from_format to throw an exception. It's arguable whether parsing a date string and expecting the h/m/s to default to 0 is valid, but this is different from previous behavior and causing problems for us.

Comments and changes to this ticket

  • rails

    rails March 7th, 2011 @ 12:00 AM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • rails

    rails March 7th, 2011 @ 12:00 AM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket