Rails Ruby on Rails

Comments and changes to this ticket

• You flagged this item as spam.
  

  Chris Hapgood December 8th, 2010 @ 01:31 PM

  This is a nice way to ensure that arguments to cache-related functions are reasonable. LH is acting up -I can't see the patch and confirm this: does the patch log generously?

  +1, conceptually.

• You flagged this item as spam.
  

  Brian Durand December 8th, 2010 @ 03:26 PM

  I didn't put in any logging. It just implements the required functions as no-ops so it always behaves like a cache miss.

• 

  Piotr Sarnacki December 10th, 2010 @ 02:38 PM

  • Importance changed from “” to “Low”

  +1 from me, I often use NoStore myself (but I call it NilStore ;).

• 

  Xavier Noria February 10th, 2011 @ 09:36 PM

  • State changed from “new” to “open”
  • Assigned user set to “Xavier Noria”

  The idea sounds good.

  We've discussed this a bit in Campfire and would like to suggest a couple of changes:

  • Instead of NoStore, NullStore is preferred, since it is a store, only it's a no-op.

  • It would be nice that config.cache_store = nil configures the NullStore.

  And since we are revising the patch... you know a patch has to be self-contained. It has to come complete with the implementation, test coverage, and documentation coverage. I know you have provided docs in a different ticket. Would you merge the corresponding documentation into the revised patched so that we get everything in the same commit?

• You flagged this item as spam.
  

  Brian Durand February 16th, 2011 @ 05:27 PM

  New patch file attached which renames the class to NullStore and lets it be set as config.cache_store = nil.

  The documentation ticket (https://rails.lighthouseapp.com/projects/8994/tickets/6309) is to update the Rails guides with changes to caching that were in the 3.0.0 release. I added reference to the changes added by this ticket so the documentation would be complete, but other than that they are independent of each other.

  • 0001-add-activesupport-cache-nullstore-to-expose-caching.patch 4.1 KB
• 

  Xavier Noria February 17th, 2011 @ 08:16 AM

  Hi Brian, thanks for the update.

  Documentation is still missing though. The other patch has other stuff, but also explains the NullStore.

  This is the patch that implements the NullStore. And thus is the patch where the documentation of NullStore has to be provided. As I commented before, the patch has to be self-contained. Code, tests, and docs. I'll amend with a line in the CHANGELOG (that's written by the committer), and up. Documentation does not have a separated workflow.

  When two months later someone does a git show of the commit, he will find everything there.

• 

  Xavier Noria February 17th, 2011 @ 09:18 AM

  Ah, just in case... My suggestion is that the docs in the other patch that cover NullStore be moved to this one. The rest of the docs you're contributing may have then their own patch, or you could push them directly via docrails if you prefer.

  The point is that when a new feature is added, the ideal is a single self-contained patch.

• You flagged this item as spam.
  

  Brian Durand February 17th, 2011 @ 04:33 PM

  I've submitted the documentation patch (less the NullStore reference) directly to docrails. I'll need to wait for that commit to be promoted to master before I can add the NullStore documentation since it needs to go in the middle of a completely rewritten section of text.

• 

  Xavier Noria February 17th, 2011 @ 04:36 PM

  Excellent, thanks very much. I'll do it myself as soon as possible, will post a followup here when done.

• 

  Xavier Noria February 18th, 2011 @ 10:26 PM

  Hi Brian, just cross-merged rails and docrails.

• You flagged this item as spam.
  

  Brian Durand February 21st, 2011 @ 06:10 PM

  Here the patch with the Rails guide update.

  • 0001-add-activesupport-cache-nullstore-to-expose-caching.patch 5.4 KB