This project is archived and is in readonly mode.
Timezone aware attributes fail with nil assignments
The "automagic" timezone conversion fails when you assign nil to a timezone aware attribute, for example:
some_model.created_at = nil
And got an ugly "TypeError: can't dup NilClass". I made an awesome and creative fix, check if the argument is nil =)
I also add a test so this will not append again.
Regards.
-
Franco Catena- Tag changed from active_record, rails, timewithzone, timezone to activerecord 3.0.4rc1 patch, patch rails 3.1.0.beta, 3.0, active_record, rails, rails3.1, timewithzone, timezone
-
Franco Catena
- Tag changed from activerecord 3.0.4rc1 patch, patch rails 3.1.0.beta, 3.0, active_record, rails, rails3.1, timewithzone, timezone to activerecord 3.0.4rc1 patch, patch rails 3.1.0.beta, 3.0, active_record, patch, rails, rails3.1, timewithzone, timezone
- Assigned user set to Aaron Patterson
After reading Ticket Assignment doc =)
-
eagle.anton (at gmail)
I can confirm this bug. Patch solves the problem.
-
eagle.anton (at gmail)
It seems like that is fixed in rails master here but rails-3-stable still isn't patched.
-
Franco Catena
Yes, is fixed in master (through a pull not a ticket), I asume this ticket is pseudo stale, except for the fact that the other patch is not backported to 3-0-stable.
-
Santiago Pastorino
- State changed from new to committed
- Importance changed from to Low
Hey thanks for letting us know guys I've just backported it.