#6386 ActiveSupport::Gzip.compress returns invalid UTF-8 strings - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6386 ✓resolved

ActiveSupport::Gzip.compress returns invalid UTF-8 strings

Reported by David Phillips | February 8th, 2011 @ 01:25 AM

ActiveSuport::Gzip.compress returns strings encoded as UTF-8:

    ruby-1.9.2-p136 :001 > ActiveSupport::Gzip.compress('').encoding
     => #<Encoding:UTF-8>

But they aren't actually UTF-8 strings:

    ruby-1.9.2-p136 :002 > ActiveSupport::Gzip.compress('').blank?
    ArgumentError: invalid byte sequence in UTF-8

Should the encoding be forced to ASCII-8BIT?

Josh Kalderimis February 9th, 2011 @ 12:07 AM
- Tag set to “active_support”
- Assigned user set to “Santiago Pastorino”
Hi David,

I have wrapped up your example into a failing test case and have whipped up a patch to correct the problem. I just need to run it by Santiago before I pop the diff up, which I'll do tomorrow morning.

Thanks,

Josh
Repository February 9th, 2011 @ 09:27 AM
- State changed from “new” to “resolved”
(from [3eb25fb8806c0b161d2d1d9cb22d0bdfc7b0ce63]) fix for AS Gzip returning a UTF-8 string in Ruby 1.9 when it is actually binary [#6386 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
https://github.com/rails/rails/commit/3eb25fb8806c0b161d2d1d9cb22d0...
Repository February 9th, 2011 @ 09:28 AM
(from [31690ea8b3420aea4ea4427e1599665d093c974f]) fix for AS Gzip returning a UTF-8 string in Ruby 1.9 when it is actually binary [#6386 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
https://github.com/rails/rails/commit/31690ea8b3420aea4ea4427e15996...
You flagged this item as spam.
David Phillips February 9th, 2011 @ 05:05 PM
Thanks Josh and José!