Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• 

  Pratik July 18th, 2008 @ 01:33 AM

  • State changed from “new” to “invalid”
  • Assigned user set to “Pratik”

  This would only happen if perform_caching is set to true in development mode. Right ?

• 

  Pratik July 18th, 2008 @ 01:33 AM

  If not, could you please post a test case or something ?

  Thanks.

• You flagged this item as spam.
  

  David Dollar July 18th, 2008 @ 02:15 AM

  It happens with default settings when using Rails.cache

  It may be hard to generate a test case since the problem spans both

  activesupport and actionpack but I'll try.

  --

  David Dollar

  ddollar@gmail.com

  On Jul 17, 2008, at 8:33 PM, Lighthouse

  wrote:

• 

  Pratik July 18th, 2008 @ 02:24 AM

  Or just paste me the relevant controller/action code from a rails app. Doesn't have to be a test case in Rails test suite.

  Thanks.

• You flagged this item as spam.
  

  David Dollar July 18th, 2008 @ 03:54 PM

  Information about reproducing the failure is here:

  http://pastie.org/236503

• You flagged this item as spam.
  

  David Reese November 11th, 2008 @ 09:20 PM

  Not sure why this is marked invalid. This behavior is clearly still happening in edge. David Dollar stated the problem clearly above, but I'll try again to make the case...

  Given the following conditions, common to a dev environment:

  • config.cache_classes = false
  • config.action_controller.perform_caching = false
  • (:memory_store selected by default)

  If you attempt to use Rails.cache.fetch in your application, like this:

  
  
  def index
    @authors = Rails.cache.fetch(:authors) { Author.find(:all) }
  end
  
  

  You will get errors after the first request, either create_time_zone_conversion... or stack level too deep errors (depending on the complexity of your app). These are caused by the combination of Rails.cache caching + cache_classes = false.

  My impression is that when perform_caching = false, caching should not actually be performed, and cache.read should return nil. This is not the case, as David Dollar points out above.

  There are two problems here: 1. perform_caching = false performs caching, which causes problems if cache_classes is off 2. The case of perform_caching = true but cache_classes = false

  It seems we could solve 1. without yet solving 2. In #785 Ryan Bates pointed this out, but the thread was then distracted by the (2) issue.

  Many other tickets (#785, #1290, #1339) talk around this issue but seem to get distracted by the class continuity/caching issue. It's certainly a frustrating issue for anyone trying to add "Rails.cache.fetch"-style caching in the development environment.

• You flagged this item as spam.
  

  David Reese November 11th, 2008 @ 11:02 PM

  darn formatting. attaching rest of last comment below.

  You will get errors after the first request, either create_time_zone_conversion... or stack level too deep errors (depending on the complexity of your app). These are caused by the combination of Rails.cache caching + cache_classes = false.

  My impression is that when perform_caching = false, caching should not actually be performed, and cache.read should return nil. This is not the case, as David Dollar points out above.

  There are two problems here: 1. perform_caching = false performs caching, which causes problems if cache_classes is off 2. The case of perform_caching = true but cache_classes = false

  It seems we could solve 1. without yet solving 2. In #785 Ryan Bates pointed this out, but the thread was then distracted by the (2) issue.

  Many other tickets (#785, #1290, #1339) talk around this issue but seem to get distracted by the class continuity/caching issue. It's certainly a frustrating issue for anyone trying to add "Rails.cache.fetch"-style caching in the development environment.

• You flagged this item as spam.
  

  David Dollar March 11th, 2009 @ 04:11 AM

  For anyone that happens to run across this ticket later:

  If you use
  

  
  @authors = cache(:authors) { Author.find(:all) }
  

  the problem goes away.

• You flagged this item as spam.
  

  Brian Armstrong July 25th, 2009 @ 12:45 PM

  Thanks David for posting that work around. I can confirm that it works, even with memcached parameters like :expires_in.

  For example you can convert this:

  @region = Rails.cache.fetch(current_subdomain, :expires_in=>1.week) do
    Region.find_by_subdomain(current_subdomain)
  end
  

  to this:

  @region = cache(current_subdomain, :expires_in=>1.week) do
    Region.find_by_subdomain(current_subdomain)
  end
  

  And it will start working again.

  This is a pretty big problem and I agree with David Reese, I don't think it should be marked invalid.

• 

  Ryan Bigg October 9th, 2010 @ 09:46 PM

  • Tag cleared.

  Automatic cleanup of spam.

• 

  Jeff Kreeftmeijer November 7th, 2010 @ 04:51 PM

  Automatic cleanup of spam.

• You flagged this item as spam.
  

  bingbing March 26th, 2011 @ 02:14 AM

  louis vuitton watches