This project is archived and is in readonly mode.
Use cover? for validates_inclusion_of with Ranges on 1.9
Range#include? behaves differently on 1.9 than on 1.8 ( http://rhnh.net/2009/08/03/range-include-in-ruby-1-9 )
In ruby 1.9 include? steps through all the values in the range, checking for equality, this is of course a lot slower, particularly for large ranges, for example date ranges
The old include? logic is available as cover?, which this patch changes validates_inclusion_of to use when checking ranges on 1.9
-
Xavier Noria- Assigned user set to Xavier Noria
-
Xavier Noria
- State changed from new to open
-
Repository- State changed from open to committed
(from [d7b539aae2dec5835d59d9d7373c96d2ec8f662d]) Change validates inclusion to use cover? for Ranges in ruby 1.9 [#6453 Use cover? for validates_inclusion_of with Ranges on 1.9 state:committed]
Signed-off-by: Xavier Noria fxn@hashref.com
https://github.com/rails/rails/commit/d7b539aae2dec5835d59d9d7373c9... -
Repository
(from [fbfa30a1eeaaab22ac8f43a4137ec8282920fe15]) Change validates inclusion to use cover? for Ranges in ruby 1.9 [#6453 Use cover? for validates_inclusion_of with Ranges on 1.9 state:committed]
Signed-off-by: Xavier Noria fxn@hashref.com
https://github.com/rails/rails/commit/fbfa30a1eeaaab22ac8f43a4137ec...