#6499 Warnings when running tests - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6499 ✓wontfix

Warnings when running tests

Reported by Lenary | March 1st, 2011 @ 08:46 PM | in 3.x

This is a generic ticket for patches relating to removing warnings. I'm basing all the changes off the warnings seen here: http://rails-ci-mri187.wyeworks.com/builds/3-0-stable and will be working on lots of patches for them over the next few weeks

Comments and changes to this ticket

You flagged this item as spam.
Lenary March 2nd, 2011 @ 01:10 PM
This patch should fix warnings about redefined methods and instance variables when running the actionmailer tests on 3-0-stable.
- 0001-fix-warnings-in-actionmailer-tests.patch 2.6 KB
Santiago Pastorino March 2nd, 2011 @ 02:56 PM
- State changed from “new” to “open”
- Milestone set to “3.x”
- Assigned user set to “Santiago Pastorino”
- Importance changed from “” to “Low”
Doesn't apply cleanly. Please rebase it.
You flagged this item as spam.
Christopher Meiklejohn March 3rd, 2011 @ 04:02 AM
I confirmed that this patch applies cleanly to the 3-0-stable; fails on master.
Santiago Pastorino March 3rd, 2011 @ 01:40 PM
We are not patching this kind of things for stable releases
You flagged this item as spam.
Lenary March 3rd, 2011 @ 07:44 PM
D'awww. time to change track i think. That said, i do think that these kinds of things should get into stable, but i understand your time constraints
Santiago Pastorino March 4th, 2011 @ 02:29 AM
- State changed from “open” to “wontfix”
Sorry Sam, but this doesn't worth the risk of breaking something in stable