Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Warnings when running tests

#6499

This is a generic ticket for patches relating to removing warnings. I'm basing all the changes off the warnings seen here: http://rails-ci-mri187.wyeworks.com/builds/3-0-stable and will be working on lots of patches for them over the next few weeks

Reported by Lenary · March 1st, 2011 @ 08:46 PM

State: wontfix
Milestone: 3.x
Assigned to: Santiago Pastorino Santiago Pastorino
Importance: Low

Activity

  1. Lenary
    Lenary

    This patch should fix warnings about redefined methods and instance variables when running the actionmailer tests on 3-0-stable.

    March 2nd, 2011 @ 01:10 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Milestone set to 3.x
    • Assigned user set to Santiago Pastorino
    • Importance changed from to Low

    Doesn't apply cleanly. Please rebase it.

    March 2nd, 2011 @ 02:56 PM

  3. Christopher Meiklejohn
    Christopher Meiklejohn

    I confirmed that this patch applies cleanly to the 3-0-stable; fails on master.

    March 3rd, 2011 @ 04:02 AM

  4. Santiago Pastorino
    Santiago Pastorino

    We are not patching this kind of things for stable releases

    March 3rd, 2011 @ 01:40 PM

  5. Lenary
    Lenary

    D'awww. time to change track i think. That said, i do think that these kinds of things should get into stable, but i understand your time constraints

    March 3rd, 2011 @ 07:44 PM

  6. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to wontfix

    Sorry Sam, but this doesn't worth the risk of breaking something in stable

    March 4th, 2011 @ 02:29 AM