Christopher Meiklejohn's profile - rails

Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Christopher Meiklejohn's latest activity

Wednesday, March 16 2011

6578 Optimistic Locking and Double Quoting of Strings was updated in Ruby on Rails

Christopher Meiklejohn commented at 6:09 PM
Just wondering if someone had a chance to take a look at the included patch?

Tuesday, March 15 2011

6578 Optimistic Locking and Double Quoting of Strings was created in Ruby on Rails

Christopher Meiklejohn created the ticket at 2:26 AM

Follow up to: https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets..., as I wasn't able to comment on that ticket (updates kept disappearing).

R...

Thursday, March 03 2011

5886 strip_tags marks as html_safe incorrectly was updated in Ruby on Rails

Christopher Meiklejohn commented at 5:28 AM

Actually, disregard.

ActionView::Helpers::SanitizeHelper specifically states that once the string is html_safe it may still contain unescaped characters.

Taken ...
Christopher Meiklejohn commented at 5:19 AM
Just verified this patch applies cleanly to master and has the desired effect.
```
ree-1.8.7-head :003 > strip_tags("<I>HI \"YOU\" </I>").html_safe?
 => false
```
Ca...

4759 `rake test(:functionals|:units|....)` loads the environment twice was updated in Ruby on Rails

Christopher Meiklejohn commented at 5:18 AM

Roger,

Keep in mind if you are running edge rails, you need to be running edge rack as well, which is probably why you are getting the SessionHash error.
Christopher Meiklejohn commented at 4:37 AM

Hi Roger,

I'm not running into any problems running the test suite on the rails master branch -- can you try doing this again?

Thanks,
Chris

6509 table_name not find in activerecord 3.0.5 sqlite3 was updated in Ruby on Rails

Christopher Meiklejohn commented at 5:03 AM

Rails 3.0.5:

ree-1.8.7-head :002 > "Chiamata".pluralize
 => "Chiamata"

Rails 3.0.4: 

ree-1.8.7-head :002 > "Chiamata".pluralize
 => "Chiamatas"

Christopher Meiklejohn commented at 5:01 AM

Confirmed. Appears a result of a fix to activesupport to fix proper pluralization.

https://github.com/rails/rails/commit/1754bd9b208e8d9207c226d1ffb3c...

Assum...

6438 request.remote_ip/X-Forwarded-For may not be an IP was updated in Ruby on Rails

Christopher Meiklejohn commented at 4:23 AM
Is the issue here just that the input isn't validated as an actual IP address?

6499 Warnings when running tests was updated in Ruby on Rails

Christopher Meiklejohn commented at 4:03 AM
I confirmed that this patch applies cleanly to the 3-0-stable; fails on master.