#6544 AS::JSON Yaml backend sometimes do not honor AS:parse_json_times - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6544 ✓committed

AS::JSON Yaml backend sometimes do not honor AS:parse_json_times

Reported by Sakuro | March 8th, 2011 @ 04:31 AM | in 3.1

ActiveSupport::VERSION::STRING "3.1.0.beta" (commit: 1408b942d9c2c131a1cdcab97f49d74ce84dae38)

>> ActiveSupport::JSON.backend = 'Yaml'
=> "Yaml"
>> ActiveSupport.parse_json_times = true
=> true
>> ActiveSupport::JSON.decode('{"timestamp":"2011-03-08T13:24:00Z"}')
=> {"timestamp"=>2011-03-08 13:24:00 UTC} #parsed, correct
>> ActiveSupport::JSON.decode('["2011-03-08T13:24:00Z"]')
=> ["2011-03-08T13:24:00Z"] #not parsed, incorrect!
>> ActiveSupport.parse_json_times = false
=> false
>> ActiveSupport::JSON.decode('{"timestamp":"2011-03-08T13:24:00Z"}')
=> {"timestamp"=>2011-03-08 13:24:00 UTC} #parsed, incorrect!
>> ActiveSupport::JSON.decode('["2011-03-08T13:24:00Z"]')
=> ["2011-03-08T13:24:00Z"] #not parsed, correct

FYI, JSONGem backend works correctly.

>> ActiveSupport::JSON.backend = 'JSONGem'
=> "JSONGem"
>> ActiveSupport.parse_json_times = true
=> true
>> ActiveSupport::JSON.decode('{"timestamp":"2011-03-08T13:24:00Z"}')
=> {"timestamp"=>Tue, 08 Mar 2011 13:24:00 +0000} #parsed, correct
>> ActiveSupport::JSON.decode('["2011-03-08T13:24:00Z"]')
=> [Tue, 08 Mar 2011 13:24:00 +0000] #parsed, correct
>> ActiveSupport.parse_json_times = false
=> false
>> ActiveSupport::JSON.decode('{"timestamp":"2011-03-08T13:24:00Z"}')
=> {"timestamp"=>"2011-03-08T13:24:00Z"} #not parsed, correct
>> ActiveSupport::JSON.decode('["2011-03-08T13:24:00Z"]')
=> ["2011-03-08T13:24:00Z"] #not parsed, correct

Comments and changes to this ticket

You flagged this item as spam.
Sakuro March 8th, 2011 @ 04:41 AM
Actually, it simply ignores parse_json_times:)
You flagged this item as spam.
Diego Carrion March 10th, 2011 @ 12:48 AM
- Tag set to “activesupport yaml”
- Assigned user set to “Santiago Pastorino”
Attached patch fixes the problem
- fix_6544.patch 4.7 KB
Santiago Pastorino March 10th, 2011 @ 01:59 AM
- State changed from “new” to “open”
- Milestone set to “3.1”
- Importance changed from “” to “Low”
You flagged this item as spam.
Diego Carrion March 13th, 2011 @ 12:04 AM
Hi Santiago, is the patch ok?
You flagged this item as spam.
John Firebaugh March 21st, 2011 @ 11:44 PM
+1, I encountered this in 3.0.5 as well.
Santiago Pastorino March 23rd, 2011 @ 12:13 AM
- State changed from “open” to “committed”
Pushed to master