Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

patch for action_view/paths PathSet#insert to make sure it applys appropriate cast

#673

PathSet attempts to make sure that any path it is given to manage is cast to a Path object if it's a string. It's inherited Array#insert will allow you to insert a string into it, causing problems later in reload! (which calls reload! on all it's children, which is defined for paths but not strings.)

This patch makes sure that insert plays by the same rules as [], unshift, and other similar methods. Infact, somebody should find all the mutating methods of Array that accept strings as in put and make sure they are overridden in PathSet to perform casts.

Reported by azimux · July 22nd, 2008 @ 08:08 AM

State: resolved
Milestone: 2.x
Assigned to: josh josh
Importance: none

Activity

  1. josh
    josh
    • State changed from new to open
    • Assigned user set to josh

    July 22nd, 2008 @ 04:31 PM

  2. Repository
    Repository
    • State changed from open to resolved

    (from [2681685450631238511cfc3c2f0fa044c1f8033a]) Extract ActiveSupport::TypedArray class to ensure an array is all of the same type [#673 state:resolved]

    http://github.com/rails/rails/co...

    July 22nd, 2008 @ 05:11 PM