This project is archived and is in readonly mode.
config.load_paths should also be frozen
Reported by José Valim | July 30th, 2008 @ 03:46 PM | in 2.x
On Rails::Initializer, configuration.load_once_paths is frozen but config.load_paths is not.
We need to freeze them so future modifications will fail rather than do nothing mysteriously. For example, I was changing the variable on my environment/development.rb and the path I was setting was never loaded.
To fix, just add the line:
configuration.load_paths.freeze
To railties/lib/initializer.rb, method set_autoload_paths, around line 214.
So we will have:
def set_autoload_paths
Dependencies.load_paths = configuration.load_paths.uniq
Dependencies.load_once_paths = configuration.load_once_paths.uniq
extra = Dependencies.load_once_paths - Dependencies.load_paths
unless extra.empty?
abort <
load_once_paths must be a subset of the load_paths.
Extra items in load_once_paths: #{extra * ','}
end_error
end
configuration.load_once_paths.freeze
end
Comments and changes to this ticket
-
José Valim July 30th, 2008 @ 03:47 PM
Ops:
def set_autoload_paths Dependencies.load_paths = configuration.load_paths.uniq Dependencies.load_once_paths = configuration.load_once_paths.uniq extra = Dependencies.load_once_paths - Dependencies.load_paths unless extra.empty? abort <<-end_error load_once_paths must be a subset of the load_paths. Extra items in load_once_paths: #{extra * ','} end_error end # Freeze the arrays so future modifications will fail rather than do nothing mysteriously configuration.load_paths.freeze configuration.load_once_paths.freeze end -
Repository October 30th, 2008 @ 08:52 PM
- State changed from “new” to “resolved”
(from [2dcdcf1552748f331bf6f6194ffddabd837bcac9]) config.load_paths should be frozen [#728 state:resolved] http://github.com/rails/rails/co...
-
Repository October 30th, 2008 @ 09:28 PM
(from [fc215de52fe1967bb00b5500c3d0dd2ad55880ac]) Revert "config.load_paths should be frozen [#728 state:resolved]"
This reverts commit 2dcdcf1552748f331bf6f6194ffddabd837bcac9. http://github.com/rails/rails/co...
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
José Valim
Repository
Referenced by
-
728
config.load_paths should also be frozen
(from [2dcdcf1552748f331bf6f6194ffddabd837bcac9])
config....
-
728
config.load_paths should also be frozen
(from [fc215de52fe1967bb00b5500c3d0dd2ad55880ac]) Revert
...