Keeping track of validations with a hash

+1 for the idea, but I'm not sure that I like this implementation.

I think we generally need some way of looking at what validations are on a model. However, I'm not sure there's an easy way to do this without completely changing the way validations are added right now.

If the patch goes in somewhat like it is now, I think the required_attributes declaration shouldn't go in base. Methods in validations.rb add in attr_accessors, so it shouldn't be a big deal to add one in the module, outside of a method.

I frequently use validates_format_of and validates_numericality_of to implicitly validate an attribute's presence.

Sorry about that, apparently I can't read the formatting instructions:

class Person < ActiveRecord::Base
  validates_uniqueness_of :name
  validates_presence_of :name, :city
end

Person.validations
=> {:uniqueness => [:name], :presence => [:name, :city]}

Looks awesome. Having this functionality is huge in DRYing up forms!

+1

Lighthouse formatting 1 x 0 me. Again:

class Person < ActiveRecord::Base
  validates_presence_of :name, :city
  validates_length_of :name, :within => 3..20,
end

Person.validations
=> {:presence => { :name => {}, :city => {} }, :length => { :name => { :within => 3..20 } }}

I think it would be even more readable if it is "attribute oriented":

Person.validations
=> {:name => { :presence => {}, :length => { :within => 3..20 } }, :city => { :presence => {} }} 

I had originally thought that keeping track of options would require a complete OO approach, with Validation objects and all sorts of nastiness that isn't really necessary.

If it can be done in a hash that's still manageable, I'm OK with that. I'm not sure it can be, though.

+1 What's the hold up here?

This will make testing validations a breeze. Things like should_validate_inclusion_of only need to assert that it's declared in the validations hash.

Didn't think there was sufficient interest...

I hadn't been following up because there were a couple of projects out there to refactor Rails validations in a much more major way, and I didn't want to step on anybody's toes.

However, I don't think that any of those projects have gotten anywhere. I'm not sure where we stand from a Rails 3 perspective, but taking another look at Validations makes too much sense.

I've implemented a full object-based validation system for another framework (which hasn't been released quite yet). I'd be happy to port it for Rails 3, but I'm not sure how much it meshes, philosophy-wise.

In my opinion

Cons: * Increased code complexity

Pros: * Easier introspection * Straightforward testing * Flexible inheritance (undoing validations in subclasses) * Form styling/logic (knowing required fields, etc)

I've needed all of these pros, so I'd say go for it.

I posted this ticket nearly a year ago and I'd still love to have this feature. I'd update my attempt, but it sounds like Erik is on the case.

Stupid formatting. Reposting lists (after previewing markdown in textmate).

Cons:

• Increased code complexity

Pros:

• Easier introspection
• Straightforward testing
• Flexible inheritance (undoing validations in subclasses)
• Form styling/logic (knowing required fields, etc)

私の中で、総合評価のとっても低いアバアバクロホリスタークロ銀座店。アバクロは大好きなんですけどね。一昨日の東京駅付近での打ち合わせの後、散歩がてら久々に行ってきました。そしたらビックリ！相変わらアバクロず、踊っているだけの店員さんとかもいましたが、