This project is archived and is in readonly mode.
eager_load_nested_include_test should not be dependent on id values
Reported by S. Brent Faulkner | August 19th, 2008 @ 03:53 PM | in 2.x
test/cases/associations/eager_load_nested_include_test.rb depends on specific primary values.
In my case, when testing ActiveRecord using MySQL, since my MySQL configuration uses a value other than 1 for auto_increment_increment, then running...
$ rake test_mysql TEST=test/cases/associations/eager_load_nested_include_test.rb
Results in the error...
1) Error:
test_include_query(EagerLoadPolyAssocsTest):
NoMethodError: undefined method non_poly' for nil:NilClass
./test/cases/associations/eager_load_nested_include_test.rb:78:in `test_include_query'
./test/cases/associations/eager_load_nested_include_test.rb:77:in `each'
./test/cases/associations/eager_load_nested_include_test.rb:77:in `test_include_query'
./test/cases/../../lib/active_record/test_case.rb:38:in `assert_queries'
./test/cases/associations/eager_load_nested_include_test.rb:76:in `test_include_query'
./test/cases/../../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:94:in `__send__'
./test/cases/../../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:94:in `run'
Comments and changes to this ticket
-
S. Brent Faulkner August 14th, 2008 @ 05:02 AM
to reproduce this problem you can either...
a) edit your my.cnf to include auto_increment_increment=5 (so that sequential id values are missing)
or
b) run the specific test more than once in a row (so that the first record created is not id == 1)
-
S. Brent Faulkner August 14th, 2008 @ 05:04 AM
- Tag changed from “activerecord, bug” to “activerecord, bug, patch, tests”
a patch is attached to remove the dependency on auto incremented id values.
as the original was implemented, the test would fail if the id values assigned to the created objects were not sequential starting at 1
the patched test will now collect the ids of the created records and select from that set instead
-
S. Brent Faulkner August 14th, 2008 @ 05:27 AM
- Assigned user set to “Michael Koziarski”
-
S. Brent Faulkner August 18th, 2008 @ 01:54 AM
As per suggestions on ruby-core...
- You should probably hold the objects, not the ids in the class arrays.
- You could use after_saves to do the storing
- You could encapsulate the 'get a random one of these' with Foo.random
I modularized the remembering and randomisation, and have attached a new patch.
-
S. Brent Faulkner August 19th, 2008 @ 03:51 PM
- Title changed from “test_include_query(EagerLoadPolyAssocsTest) fails for test_mysql when auto_increment_increment != 1” to “eager_load_nested_include_test should not be dependent on id values”
-
Michael Koziarski August 21st, 2008 @ 03:45 PM
- State changed from “new” to “committed”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Michael Koziarski
S. Brent Faulkner