This project is archived and is in readonly mode.

#89 ✓resolved
nex3

Errors in partials are reported as occurring in parent templates

Reported by nex3 | May 1st, 2008 @ 09:38 PM

When an error is raised in a partial template, it's only wrapped by TemplateError once it bubbles up to Base#render_file. This means that the Template object passed to TemplateError.new is the toplevel object rather than the PartialTemplate object. Since TemplateError uses this object to figure out the filename and line number of the error, the error message is entirely wrong.

This patch fixes this by delegating error-catching responsibilities to the Template object. This means that each Template will wrap its own errors at the proper time.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages