Layout MIME type should match the response's

Re-uploaded the failing test as there was a typo in the failing assertion.

Uploaded a second patch: the same test that was failing, along with an attempt at solving the problem.

The mime_responds_test.rb test suite now passes when run alone.

Unfortunately, when running the full ActionPack test suite, another assertion fails inside the new test, for no apparent reason.

The only change I made is to remove the line @template_format = :html in ActionView::Base#pick_template. I don't understand what goes wrong when running the full suite; hopefully somebody can help me on this.

Oops, fixed the filename of the last patch.

Joshua:

The 2nd patch fixes the bug as the (new) test passes. Plus, I use Rails with this patch applied in one of my projects and I noticed that that bug is now actually gone.

What is weird though, is that when the test suite is run in its entirety, an assertion within the same test (but different from the one which failed originally) then fails. Like some other test messed with the code and did not restore it to its original state afterward.

"test_layout_mime_should_match_responses should be broken up into separate cases": agreed.

Actually, not long after creating this ticket, I rewrote ActionView::Base#pick_template so that it behaves more consistently. And it's been working like a charm since then.

Currently, the rewrite is packaged in a plug-in and I haven't taken the time to make a patch for Rails out of it. I just put it up on GitHub for you to take a look and perhaps have a stab at it:

http://github.com/Roman2K/action...