Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Will Bryant

Will Bryant

Not a member

Will Bryant's latest activity

Wednesday, May 26 2010
3979 [PATCH] Join conditions removed on habtm and has many through with conditions... was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 5:17 AM

    David, is this still an issue on master?
3678 Small tweak to fix unnecessary duping and loading was updated in Ruby on Rails
  • Will Bryant
    • Assigned user cleared.
    by Will Bryant at 5:01 AM

    Attached rebased patch against master, as the same improvement still applies to 3.0.
Monday, January 11 2010
3683 Add :preload option to find was created in Ruby on Rails
  • Will Bryant
    Will Bryant created the ticket at 10:40 AM

    This patch adds support for a :preload option, which functions much like the "new" :include path - but it will always use that rather than falling back to the o...
Sunday, January 10 2010
3678 Small tweak to fix unnecessary duping and loading was created in Ruby on Rails
  • Will Bryant
    Will Bryant created the ticket at 12:15 AM

    Commit 8056c57 fixed #2397, but it introduces a little inefficiency to every non-dirty record save - it calls attributes rather than using @attributes, resultin...
Saturday, January 02 2010
2976 has_one :through preload drops conditions was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 10:50 PM

    Hi Frederick,

    is this something we're working on for the 2-3-stable series, or do you plan to leave it till Rails 3.0?
Monday, December 14 2009
1827 has_many collection(force_reload=TRUE) hits cache under lock! was updated in Ruby on Rails
  • Will Bryant
    • Assigned user set to josh
    • Tag changed from 2.1.1, activerecord, collection, has_many, lock, transaction to 2.1.1, 2.3.x, activerecord, collection, has_many, lock, query_cache, transaction
    by Will Bryant at 4:43 AM

    This affects one of my projects too - we're not using clear, but we are locking and using (true) to check for the current record - very bad thing happened when ...
Thursday, August 13 2009
2976 has_one :through preload drops conditions was updated in Ruby on Rails
  • Will Bryant
    • Assigned user set to Frederick Cheung
    by Will Bryant at 2:05 AM

    Here's a test case showing the problem.

    Frederick, it looks to me like in the case where there are conditions on the source table, we can't do the loading in tw...
Wednesday, August 05 2009
2984 Warn when parameters to functional test requests have improper values was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 1:36 AM

    No, that's an example of an inaccurate test pass due to the integer parameter being passed through to the controller as an integer.

    What Koz and I are talking a...
  • Will Bryant
    Will Bryant commented at 12:47 AM

    @Yehuda, can you suggest a scenario where automatically converting IDs/other integers to strings, like they would come in from HTTP, would make a test accidenta...
Tuesday, August 04 2009
2946 quoted_date converts time objects to default_timezone was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 11:51 AM

    Yeah, we've fixed other timezone-handling bugs of similar magnitude in minor 2.x releases, so I'd vote for this to be applied to 2.3 too, personally.