Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

Will Bryant's latest activity

Monday, May 11 2009
2591 Passing in Fixnum to First/Last Finders was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 2:36 AM

    +1 This inconsistency bugs me too. This patch works in my project and passes tests.

Wednesday, May 06 2009
2269 Enumerable#sum not called on some association collections was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 4:15 AM

    This is the expected current behaviour. Calling some_has_many.sum calls the Calculations module sum, which passes the string argument you give it to the databas...

Thursday, April 09 2009
2462 sanitize_sql_hash_for_conditions uses incorrect table_name was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 3:27 AM

    Use :conditions => {:authors => {:name => 'BAR'}}. AFAIK :conditions => {'authors.name' => 'BAR'} has never been officially supported, though it may have worked...

Thursday, March 19 2009
2189 count breaks has_many through association collection with named scope was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 3:46 AM

    I would prefer substituting the primary key, personally, as I feel it makes it more clear what we're doing and makes me less nervous about counts with joins (wh...

Wednesday, March 11 2009
2213 Saving objects with associated has_one :throughs loaded broken was created in Ruby on Rails
  • Will Bryant
    Will Bryant created the ticket at 1:17 PM

    5cda000, which changed the autosave logic between rc1 & rc2, broke the save of any objects that have has_one :through associations :included.

    The attached patch...

2179 ActiveResource not eager loading namespaced models was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 11:28 AM

    Do you know if this a regression from 2.2 or something that's never worked?

2189 count breaks sqlite has_many through association collection with named scope was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 10:53 AM

    This affects mysql 5.0 also, and is definitely a regression.

Friday, March 06 2009
2158 :having conditions need sanitizing was created in Ruby on Rails
  • Will Bryant
    Will Bryant created the ticket at 10:16 PM

    The recently-introduced :having support isn't sanitizing the conditions, so whereas:

    :having => 'sum(credit_limit) > 50'

    works,

    :having => ['sum(credit_limit) >...

Monday, February 16 2009
1837 PostgresSQLAdapter#unescape_bytea does not handle "\\" was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 3:25 AM

    The reason that I ask is that a lot of the weird stuff we do in postgres was introduced to deal with problems with the gems, and unfortunately it sticks around ...

Wednesday, February 11 2009
1935 Array.wrap handling of association collections was created in Ruby on Rails
  • Will Bryant
    Will Bryant created the ticket at 1:55 AM

    Array.wrap doesn't DWIM with associations:

    Array.wrap(Icp.find(16).registers) => [[#<Register ...>]]

    Array.wrap(DisputedRead.unresolved) => [[#<DisputedRead ....