Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

hjdivad

hjdivad

Not a member

hjdivad's latest activity

Thursday, September 02 2010
5137 [PATCH] has_one :through through belongs_to associations does not build throu... was updated in Ruby on Rails
  • hjdivad
    hjdivad commented at 7:31 PM

    Neeraj,

    The test for invoking association.reload was to handle the following case,
    exhibited in a test in test/cases/associations/belongs_to_association_test.rb...
Wednesday, September 01 2010
5137 [PATCH] has_one :through through belongs_to associations does not build throu... was updated in Ruby on Rails
  • hjdivad
    hjdivad commented at 12:08 AM

    Neeraj,

    Thank you for looking into this.

    Your code above does not test the problem: there, you have a has_one (dashboard)
    through a has_one(speedometer).

    If you...
Monday, July 26 2010
5137 [PATCH] has_one :through through belongs_to associations does not build throu... was updated in Ruby on Rails
  • hjdivad
    hjdivad commented at 6:47 PM

    No worries (^_^)
  • hjdivad
    hjdivad commented at 6:38 PM

    I'm fairly sure the linked commit actually resolves 5173, and not this bug.
Saturday, July 17 2010
5137 [PATCH] has_one :through through belongs_to associations does not build throu... was updated in Ruby on Rails
  • hjdivad
    hjdivad commented at 4:27 AM

    In case it's not clear, the patch handles the test_forgetting_the_load_when_foreign_key_enters_late test (as well as the rest of the activerecord test suite, at...
  • hjdivad
    hjdivad commented at 4:26 AM

    The above test fails in the block because the association proxy is nil, because
    of the following code:

        # 38f1ea8fe267947f4baf832d3b15ee5b83f18f71
    # ass...
  • hjdivad
    hjdivad commented at 4:20 AM
  • hjdivad
    hjdivad created the ticket at 4:18 AM

    The following test should illustrate the problem:

        class Minivan < ActiveRecord::Base
      set_primary_key :minivan_id

      belongs_to :speedometer
     ...
Thursday, July 15 2010
5089 ActiveSupport::Callbacks :rescuable => true does not work for errors in :befo... was updated in Ruby on Rails
  • hjdivad
    • Tag changed from activesupport, callbacks to activesupport, callbacks, patch
    by hjdivad at 9:44 PM

    I have uploaded a better patch than the original, and also updated the git
    branch. My original patch broke callbacks with :before and :around with
    :rescuable =>...
Monday, July 12 2010
5089 ActiveSupport::Callbacks :rescuable => true does not work for errors in :befo... was updated in Ruby on Rails
  • hjdivad
    • Title changed from ActiveSupport::Callbacks :rescuable => true does not work for errs in :before callbacks [Patch] to ActiveSupport::Callbacks :rescuable => true does not work for errors in :before callbacks [Patch]
    by hjdivad at 3:25 AM