Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Hongli Lai's latest activity

Tuesday, December 15 2009
3577 Failsafe middleware should flush the logger was created in Ruby on Rails
  • Hongli Lai
    Hongli Lai created the ticket at 8:27 PM

    Currently the failsafe middleware does not flush the logger when logging the exception. As a result the error is not always written to the log file. The attache...

Friday, August 21 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 8:41 PM

    Here's a preview patch which shows how it's done in master. I don't have any unit tests yet.

Sunday, August 16 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 8:05 AM

    Ticket state should be 'incomplete'. Needs to be ported to master.

Saturday, August 15 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 8:35 PM

    My last patch broke some unit tests. This fixes it.

Tuesday, August 11 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 1:42 PM

    It looks like my previous patch was inadequate. Accessing a metal piece in development mode under high concurrency still fails with reload errors. The problem i...

  • Hongli Lai
    Hongli Lai commented at 12:42 PM

    After several hours of debugging I managed to find the cause of the problem. The Dispatcher was holding references to old metal objects. So even though we reloa...

  • Hongli Lai
    Hongli Lai commented at 11:31 AM

    It looks like the problem isn't related to the Reloader but to something else. A test case can be created as follows:

    rails reloadtest  (using Rails 2.3.3's 'r...
  • Hongli Lai
    Hongli Lai commented at 11:03 AM

    It seems I spoke too soon. With some changes I was able to reproduce the problem with both 2.3.3 and 2-3-stable. Investigating this...

  • Hongli Lai
    Hongli Lai commented at 10:44 AM

    @Stephen: yes it's supposed to be fixed. You shouldn't had to make those changes in your code.

    I'm unable to reproduce the problem using Flip Sasser's test case...

Monday, August 10 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 9:31 PM

    Good call. Here's a patch which fixes this problem and also happens to fix a unit test that I didn't write correctly last time.

    Amazing how so many things can g...