Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Hongli Lai's latest activity

Saturday, August 01 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 11:55 AM

    Yes it is. The reloader is only inserted into the middleware stack when cache_classes = false:

    unless cache_classes
      unless self.middleware.include?(Reloader)...
Friday, July 31 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 2:36 PM

    This patch fixes the issue.

  • Hongli Lai
    Hongli Lai commented at 2:08 PM

    I've seen this in Mongrel but not in Phusion Passenger. I thought it was a fluke but apparently not.

    I think it's related to locking. The Rails lock should be r...

Thursday, July 09 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 9:59 AM

    I'll have a look at it for master.

Tuesday, July 07 2009
2873 Application reloading should be deferred to end of request, currently interfe... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 8:39 PM

    No I don't. The code reloader on master is significantly different so it's not just a simple port.

2879 auto_increment on create_table option is not included on schema.rb was updated in Ruby on Rails
Monday, July 06 2009
2874 Mocha 0.9.7 is required for ActionPack unit tests was created in Ruby on Rails
  • Hongli Lai
    Hongli Lai created the ticket at 1:24 PM

    The ActionPack unit tests specify 0.9.5 as the minimum version, but 0.9.7. The attached patch for Rails 2.3 fixes this problem.

2873 Application reloading should be deferred to end of request, currently interfe... was created in Ruby on Rails
  • Hongli Lai
    Hongli Lai created the ticket at 1:19 PM

    Consider the following:

    render :text => lambda { |response, output|

    User.each do |user|
      output.write("#{user.username}\n")
    end
    

    }

    This doesn't work correctly...

Sunday, July 05 2009
2468 [PATCH] active_record/schema_dumper.rb gets confused by a non-integer column ... was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 9:19 AM

    It's not good to remove "pk ||= 'id'" because @connection.pk_and_sequence_for can return nil.

    I'm also not sure whether your approach is a good idea. Wouldn't i...

2868 Dumping of non-standard primary keys doesn't work with SQLite3 adapter was updated in Ruby on Rails
  • Hongli Lai
    Hongli Lai commented at 9:08 AM

    Same patch for master.