Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Ben Hollis

Ben Hollis

Not a member

Ben Hollis's latest activity

Friday, February 25 2011
5720 ActiveSupport::Benchmarkable.benchmark double-renders was updated in Ruby on Rails
  • Ben Hollis
    Ben Hollis commented at 6:40 PM

    Hey Aaron, thanks for taking another look at this. I agree that new helpers should just use capture, but what about existing helpers (and methods that use yield...
Wednesday, February 16 2011
5720 ActiveSupport::Benchmarkable.benchmark double-renders was updated in Ruby on Rails
  • Ben Hollis
    Ben Hollis commented at 9:00 AM

    It appears that just applying the changes to actionpack/lib/action_view/template/handlers/erb.rb (deleting ActionView::OutputBuffer#append_if_string= and Action...
  • Ben Hollis
    Ben Hollis commented at 8:43 AM

    I futzed around with git bisect, and it looks like ba52748d05da4f95a8f371d628af97b76644bdd3 was the commit that introduced the fix: https://github.com/rails/ra...
Wednesday, September 29 2010
5720 ActiveSupport::Benchmarkable.benchmark double-renders was updated in Ruby on Rails
  • Ben Hollis
    Ben Hollis commented at 7:35 AM

    Oops, forgot to mention, this is on 3.0.0.
Tuesday, September 28 2010
5720 ActiveSupport::Benchmarkable.benchmark double-renders was created in Ruby on Rails
  • Ben Hollis
    Ben Hollis created the ticket at 9:01 AM

    This can be seen if you create a view that contains:

    <% benchmark("Bug") do %>
  Hello
<% end %>
    If you view that, you'll see "Hello" printed twice. I'd expec...